wayland/shortcuts-inhibit: add shortcuts inhibitor #277
Conversation
|
This does not look helpful for creating keybinds and I can't think of much to use it for apart from making misguided lock screens that don't work properly. Can you explain exactly what you want to do with it and why having your compositor run qs ipc does not solve it? |
Specifically, I want to integrate a settings screen for configuring niri keybinds into my shell. Which is now possible with niris config include branch. It's not possible to have a keybind input field without it. (If I want to overwrite one that's already bound) |
rec_1759233568.mp4This is the type of input field I have in mind |
outfoxxed
left a comment
outfoxxed
left a comment
There was a problem hiding this comment.
I've gone over the protocol and the implementation, and most of it is missing here. To merge this we'll need to be able to tell if the compositor takes away the inhibitor or it disappears due to focus loss.
Additionally, only one inhibitor object can be created at a time per surface or a protocol error will be raised and quickshell will crash, so merge them.
bbedward
force-pushed
the
add-zwp-shortcut-inhibit
branch
from
f484db0 to
21eb42f
Compare
|
I added an |
bbedward
force-pushed
the
add-zwp-shortcut-inhibit
branch
from
21eb42f to
a764cec
Compare
| this->onWindowVisibilityChanged(); | ||
| } | ||
|
|
||
| emit this->windowChanged(); |
There was a problem hiding this comment.
It looks like window and bBoundWindow should be pretty much unrelated. As window hasn't changed here, it shouldn't update. If the window is actually connected should be transparent to the window property.
| ShortcutsInhibitor* | ||
| ShortcutsInhibitManager::createShortcutsInhibitor(QtWaylandClient::QWaylandWindow* surface) { | ||
| auto* display = QtWaylandClient::QWaylandIntegration::instance()->display(); | ||
| auto* inputDevice = display->lastInputDevice(); | ||
| if (inputDevice == nullptr) inputDevice = display->defaultInputDevice(); | ||
|
|
||
| if (inputDevice == nullptr) { | ||
| qCCritical(logShortcutsInhibit) << "Could not create shortcuts inhibitor: No seat."; | ||
| return nullptr; | ||
| } | ||
|
|
||
| auto* wlSurface = surface->surface(); | ||
|
|
||
| if (this->inhibitors.contains(wlSurface)) { | ||
| auto* inhibitor = this->inhibitors.value(wlSurface); | ||
| this->refCounts[inhibitor]++; | ||
| qCDebug(logShortcutsInhibit) << "Reusing existing inhibitor" << inhibitor << "for surface" | ||
| << wlSurface << "- refcount:" << this->refCounts[inhibitor]; | ||
| return inhibitor; | ||
| } | ||
|
|
||
| auto* inhibitor = | ||
| new ShortcutsInhibitor(this->inhibit_shortcuts(wlSurface, inputDevice->object()), wlSurface); | ||
| this->inhibitors.insert(wlSurface, inhibitor); | ||
| this->refCounts.insert(inhibitor, 1); | ||
| qCDebug(logShortcutsInhibit) << "Created inhibitor" << inhibitor << "for surface" << wlSurface; | ||
| return inhibitor; | ||
| } |
There was a problem hiding this comment.
We should return an existing inhibitor if we have one that matches.
There was a problem hiding this comment.
It is if it already exists for the surface
bbedward
force-pushed
the
add-zwp-shortcut-inhibit
branch
from
27b5ae9 to
a77f9b0
Compare
2 participants
Implement keyboard-shortcuts-inhibit-unstable-v1
There's probably a few use cases for this in quickshell, but the one i'm interested in is getting an interface for creating keybinds. Without it it gets eaten by the compositor.
Usage is as follows: