Skip to content

Breaking: error on unordered or reverse indices #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rafaqz wants to merge 10 commits into
base: breaking
Choose a base branch
from
Open

Breaking: error on unordered or reverse indices #847

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6e96e27
set lookups as Unordered after Vector{Int} indexing
rafaqz Nov 3, 2024
93ad378
check AbstractVector{Int} index sorted order
rafaqz Nov 3, 2024
49acbcb
Merge branch 'breaking' into unordered_after_vec_int
rafaqz Nov 5, 2025
fa2ec72
add local and global short circuits for checkorder
rafaqz Nov 5, 2025
72ba19a
dont remove whitespace
rafaqz Nov 5, 2025
930a7cc
fix ambiguities
rafaqz Nov 5, 2025
fa804ac
bugfix and reorganise
rafaqz Nov 6, 2025
0332371
fix ambiguity
rafaqz Nov 8, 2025
26469d1
fix tests name
rafaqz Nov 8, 2025
1fe2468
move Statistics to extras
rafaqz Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Lookups/indexing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,14 @@ for f in (:getindex, :view, :dotview)
@propagate_inbounds Base.$f(l::Lookup, i::Union{Int,CartesianIndex}) =
Base.$f(parent(l), i)
# AbstractArray, Colon and CartesianIndices: the lookup is rebuilt around a new parent
@propagate_inbounds Base.$f(l::Lookup, i::Union{AbstractArray,Colon}) =
@propagate_inbounds Base.$f(l::Lookup, i::Union{AbstractVector,Colon}) =
rebuild(l; data=Base.$f(parent(l), i))
@propagate_inbounds function Base.$f(l::Union{Sampled,Categorical}, i::AbstractVector{Int})
if isordered(l)
issorted(i) || throw(ArgumentError("For `ForwardOrdered` or `ReverseOrdered` lookups, indices of `AbstractVector{Int}` must be in ascending order"))
end
rebuild(l; data=Base.$f(parent(l), i))
end
# Selector gets processed with `selectindices`
@propagate_inbounds Base.$f(l::Lookup, i::SelectorOrInterval) = Base.$f(l, selectindices(l, i))
@propagate_inbounds function Base.$f(l::Lookup, i)
Expand Down
Loading