Skip to content

Fix for checking if raw connection transaction open #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Fix for checking if raw connection transaction open #1296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/cases/coerced_tests.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2805,10 +2805,11 @@ def test_with_recursive_coerced

module ActiveRecord
class AdapterConnectionTest < ActiveRecord::TestCase
# Original method defined for core adapters.
# Original method only handled the core adapters.
undef_method :raw_transaction_open?
def raw_transaction_open?(connection)
connection.instance_variable_get(:@raw_connection).query("SELECT @@trancount").to_a[0][0] > 0
transaction_count = connection.instance_variable_get(:@raw_connection).execute("SELECT @@TRANCOUNT AS TRANSACTION_COUNT").first["TRANSACTION_COUNT"]
transaction_count > 0
rescue
false
end
Expand Down
Loading