Skip to content

Conversation

@sampan-s-nayak
Copy link
Contributor

Description

  • Use client interceptor for adding auth tokens in grpc calls when AUTH_MODE=token
  • BuildChannel() will automatically include the interceptor
  • Removed auth_token parameter from ClientCallImpl
  • removed manual auth from python_gcs_subscriber.cc
  • tests to verify auth works for autoscaller apis

sampan added 2 commits November 6, 2025 06:30
Signed-off-by: sampan <sampan@anyscale.com>
@sampan-s-nayak sampan-s-nayak requested a review from a team as a code owner November 6, 2025 06:41
@sampan-s-nayak sampan-s-nayak changed the base branch from master to token_auth_11 November 6, 2025 06:41
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a robust token-based authentication mechanism for the Ray dashboard UI and gRPC communications. The implementation is well-designed, leveraging gRPC interceptors for both client and server to transparently handle token injection and validation. This is a clean approach that avoids manual token handling in every RPC call. The dashboard's HTTP server is also correctly updated with middleware to protect endpoints, while whitelisting necessary public paths for the UI to function. The frontend changes, including the authentication dialog and global error handling via an axios interceptor, are solid. The addition of comprehensive unit, integration, and frontend tests is commendable. I have one suggestion to reduce code duplication in the Python gRPC client interceptor.

@sampan-s-nayak sampan-s-nayak added the go add ONLY when ready to merge, run all tests label Nov 6, 2025
@ray-gardener ray-gardener bot added the core Issues that should be addressed in Ray Core label Nov 6, 2025
Signed-off-by: sampan <sampan@anyscale.com>
@sampan-s-nayak sampan-s-nayak changed the title [core] Support token based auth in ray dashboard UI [core] use client interceptor for adding auth token in c++ client calls Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants