py3.10 migration work #58453
py3.10 migration work #58453
Conversation
- run modin tests in python 3.10, which depends on datalbuild - fixes data dashboard test dependency - fixes data flaky test dependency Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
…work Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Buildkite CI configuration by moving documentation-related build and linting steps into a separate doc.rayci.yml file. It also introduces new requirements for Python 3.10. The CI refactoring looks good, but I've found several issues in the new release/requirements_py310.in file. There are multiple dependencies with versions that do not exist on PyPI, which will cause build failures. I've left comments with suggestions to fix them. There is also a redundant dependency declaration that should be cleaned up.
| pybuildkite | ||
| PyGithub | ||
| requests | ||
| twine == 6.1.0 |
There was a problem hiding this comment.
The specified version 6.1.0 for twine does not exist on PyPI. The latest version is 5.1.0. This is likely a typo and will cause a build failure. Please correct the version.
twine == 5.1.0
|
|
||
| # Upgrades | ||
| typing-extensions>=4.10 | ||
| jsonschema>=4.23.0 |
There was a problem hiding this comment.
The specified version constraint jsonschema>=4.23.0 is for a version that does not exist on PyPI. The latest version is 4.22.0. This will cause a dependency resolution failure. Please correct the version constraint.
jsonschema>=4.22.0
| typing-extensions>=4.10 | ||
| jsonschema>=4.23.0 | ||
| certifi>=2025.1.31 | ||
| h11>=0.16.0 |
There was a problem hiding this comment.
The specified version constraint h11>=0.16.0 is for a version that does not exist on PyPI. The latest version is 0.14.0. This will cause a dependency resolution failure. Please correct the version constraint.
h11>=0.14.0
| pyyaml | ||
| pybuildkite | ||
| PyGithub | ||
| requests |
There was a problem hiding this comment.
The requests package is specified here without a version, and again on line 26 with a version constraint (>= 2.31.0). This is redundant. To avoid confusion and keep the requirements file clean, please remove this line. The more specific constraint on line 26 will be used.
No description provided.