[train] Updating "Checkpoint Report Time" Metric Title to "Cumulative Checkpoint Report Time" #58470
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JasonLi1909 <jasli1909@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the title and description for the 'Checkpoint Report Time' metric panel in the Ray Train dashboard. The new title 'Cumulative Checkpoint Report Time' and the updated description accurately reflect that the metric is a cumulative sum of time spent reporting checkpoints. This is a good clarification that improves the user experience of the dashboard. The changes are correct and well-implemented.
ray-gardener
bot
added
train
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing Checkpoint Report Time metric represents the total time workers spend reporting metrics across multiple checkpoints. However, the current title does not clearly indicate that this time is cumulative. This PR addresses the issue by renaming the panel to “Cumulative Checkpoint Report Time” and updating the description to reflect that it sums reporting time across multiple checkpoints.
Current State:
