Skip to content

fix: double onchange and render double number pointer in input when i… #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: double onchange and render double number pointer in input when i… #275

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edb62e6
fix: double onchange and render double number pointer in input when i…
405go Nov 6, 2020
c583bda
update: merger regexp simple
405go Nov 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/InputNumber.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ class InputNumber extends React.Component<Partial<InputNumberProps>, InputNumber

onChange = e => {
const { onChange } = this.props;

if (this.state.focused) {
this.inputting = true;
}
Expand Down Expand Up @@ -324,7 +323,10 @@ class InputNumber extends React.Component<Partial<InputNumberProps>, InputNumber
getValueFromEvent(e) {
// optimize for chinese input expierence
// https://github.com/ant-design/ant-design/issues/8196
let value = e.target.value.trim().replace(/。/g, '.');
let value = e.target.value
.trim()
.replace(/。/g, '.')
.replace(/\.+/g, '.');

Copy link
Member

@yoyo837 yoyo837 Nov 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能合成一个吗

Copy link
Author

@405go 405go Nov 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i got it

if (isValidProps(this.props.decimalSeparator)) {
value = value.replace(this.props.decimalSeparator, '.');
Expand Down