Setup Hermes V1 testing #45
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipolleschi
requested changes
Nov 7, 2025
| @@ -0,0 +1,206 @@ | |||
| name: test-hermes-v1 | |||
| description: Tests a library on a nightly | |||
Contributor
There was a problem hiding this comment.
This should be adapted, I think
Contributor
There was a problem hiding this comment.
Also, a reusable workflow is probably better.
Contributor
There was a problem hiding this comment.
We can probably collapse this in the hermesv1.yml workflow, to be fair.
Given that there are some steps specific to Android and some other specific to iOS, we could even have a setup_maestro action that is shared and two different workflows: one for android and one for iOS
Contributor
Author
There was a problem hiding this comment.
The new setup is:
- setup maestro action
- setup app with Hermes V1 action
- build & test android app
- build & test ios app
I also moved collecting result to check-nightly workflow, so it's able to pick up results from library tests, as well as hermes v1.
j-piasecki
force-pushed
the
@jpiasecki/test-hermes-v1
branch
from
9764245 to
d89a744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sets up automated testing of Hermes V1. The workflow will set up a new RN app from the template, enable Hermes V1, build the app, and run a simple E2E test using it.
E2E is based on the setup used in the React Native repository:
maestro-ios.jsmaestro-android.jsstart.ymlIf I understand the repository setup correctly, to pick up the results of the actions and show them on the website, the action needs to upload GitHub artifacts in a specific format, which I believe the new workflow does. Please correct me if I'm wrong.