-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add support for Sphinx 9.0.0 #1666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: humitos <244656+humitos@users.noreply.github.com>
humitos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
|
I pulled this PR and installed it from the source. It worked fine. I was able to build the documentation with Sphinx 9.x and it worked. |
| so we are not supporting it on newer versions, | ||
| starting on 3.0.0. | ||
|
|
||
| 3.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the right place to document the version. This document is describing major development releases, not minor releases. We've been updating the changelog page with versions and future versions/RCs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I feel we should bump the version to an RC so users installing this package via Git have the latest RC at hand. We don't need to release to PyPI yet, but that's the next step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the right place to document the version. This document is describing major development releases, not minor releases.
We have 1.1.0 in the section. That's why I added it here.
https://sphinx-rtd-theme.readthedocs.io/en/stable/development.html#roadmap-release-1-1-0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I feel we should bump the version to an RC so users installing this package via Git have the latest RC at hand. We don't need to release to PyPI yet, but that's the next step
OK. I pushed 9f6556b with changelog and rc version.
sphinx_rtd_themepins Sphinx to<9, preventing installation with Sphinx 9.0.0.Changes
sphinx >=6,<9tosphinx >=6,<10sphinx90test environment for Sphinx 9.0.xExisting tests pass with Sphinx 9.0.0.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dev.readthedocs.io/home/REDACTED/.local/bin/sphinx-build sphinx-build -b html -Dhtml4_writer=0 docs/ /tmp/html(dns block)docs.readthedocs.io/home/REDACTED/.local/bin/sphinx-build sphinx-build -b html -Dhtml4_writer=0 docs/ /tmp/html(dns block)www.sphinx-doc.org/home/REDACTED/.local/bin/sphinx-build sphinx-build -b html -Dhtml4_writer=0 docs/ /tmp/html(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.