-
Notifications
You must be signed in to change notification settings - Fork 24
RHAIENG-948: remove UBI 9 repository injection across all Dockerfiles #1696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHAIENG-948: remove UBI 9 repository injection across all Dockerfiles #1696
Conversation
|
/build-konflux |
1 similar comment
|
/build-konflux |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ysok The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ysok I can't do this, the 3.0 images that still have IBM arches support don't have their own repos in them. AIPCC first removed IBM arches support and only then started preserving repo files in /etc/yum.repos.d/ |
|
@jiridanek it was ubi9 that has those repos (may included IBM?), but since we switched to aipcc, it is RHEL9. I've tried both cpu:3.0-1761580156 and cpu:3.1-1762903336, since they don't have subcription manager, dnf upgrade did shrink their /etc/yum.repos.d/redhat.repo to almost empty, no enabled repos. We have to change and test each dockerfile with AIPCC image to make sure they can be built successfully, I had to use mcurlej's copr. `podman run --rm -it --platform linux/x86_64 --user root quay.io/aipcc/base-images/cpu:3.1-1762903336 bash -c "ls -alh /etc/yum.repos.d/redhat.repo && dnf upgrade || true && ls -alh /etc/yum.repos.d/redhat.repo" -rw-r--r--. 1 root root 300K Nov 11 23:21 /etc/yum.repos.d/redhat.repo -rw-r--r--. 1 root root 359 Nov 14 00:40 /etc/yum.repos.d/redhat.repo` |
a4ca915 to
661554c
Compare
|
New changes are detected. LGTM label has been removed. |
661554c to
caf41a4
Compare
|
/build-konflux |
caf41a4 to
1ab2215
Compare
|
/build-konflux |
|
If we stick to the 3.0 aipcc images we use now, then this can't be done. We need to have some package registries enabled because we install packages. |
1ab2215 to
ff96bb1
Compare
|
/build-konflux |
1 similar comment
|
/build-konflux |
```
+ dnf install -y perl mesa-libGL skopeo gcc gcc-c++ make openssl-devel autoconf automake libtool cmake python3-devel pybind11-devel openblas-devel unixODBC-devel
Updating Subscription Management repositories.
Red Hat Universal Base Image 9 (RPMs) - BaseOS 1.4 MB/s | 433 kB 00:00
Red Hat Universal Base Image 9 (RPMs) - AppStre 6.4 MB/s | 2.2 MB 00:00
Red Hat Universal Base Image 9 (RPMs) - CodeRea 683 kB/s | 174 kB 00:00
Package mesa-libGL-24.2.8-3.el9_6.s390x is already installed.
Package skopeo-2:1.20.0-1.el9.s390x is already installed.
Package gcc-11.5.0-11.el9.s390x is already installed.
Error:
Problem: package mesa-dri-drivers-25.0.7-3.el9_7.s390x from ubi-9-appstream-rpms requires libLLVM.so.20.1()(64bit), but none of the providers can be installed
- package mesa-dri-drivers-25.0.7-3.el9_7.s390x from ubi-9-appstream-rpms requires libLLVM.so.20.1(LLVM_20.1)(64bit), but none of the providers can be installed
- cannot install both llvm-libs-20.1.8-3.el9.s390x from ubi-9-appstream-rpms and llvm-libs-19.1.7-2.el9.s390x from @System
- package mesa-libGL-25.0.7-3.el9_7.s390x from ubi-9-appstream-rpms requires libgallium-25.0.7.so()(64bit), but none of the providers can be installed
...
```
# Conflicts:
# codeserver/ubi9-python-3.12/Dockerfile.cpu
# jupyter/datascience/ubi9-python-3.12/Dockerfile.cpu
# jupyter/minimal/ubi9-python-3.12/Dockerfile.cpu
# jupyter/minimal/ubi9-python-3.12/Dockerfile.cuda
# jupyter/minimal/ubi9-python-3.12/Dockerfile.rocm
# jupyter/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.cuda
# jupyter/pytorch/ubi9-python-3.12/Dockerfile.cuda
# jupyter/rocm/pytorch/ubi9-python-3.12/Dockerfile.rocm
# jupyter/rocm/tensorflow/ubi9-python-3.12/Dockerfile.rocm
# jupyter/tensorflow/ubi9-python-3.12/Dockerfile.cuda
# jupyter/trustyai/ubi9-python-3.12/Dockerfile.cpu
# runtimes/minimal/ubi9-python-3.12/Dockerfile.cpu
# runtimes/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.cuda
# runtimes/pytorch/ubi9-python-3.12/Dockerfile.cuda
# runtimes/rocm-pytorch/ubi9-python-3.12/Dockerfile.rocm
# runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.rocm
# runtimes/tensorflow/ubi9-python-3.12/Dockerfile.cuda
# Conflicts:
# codeserver/ubi9-python-3.12/Dockerfile.konflux.cpu
# jupyter/datascience/ubi9-python-3.12/Dockerfile.konflux.cpu
# jupyter/minimal/ubi9-python-3.12/Dockerfile.konflux.cpu
# jupyter/minimal/ubi9-python-3.12/Dockerfile.konflux.cuda
# jupyter/minimal/ubi9-python-3.12/Dockerfile.konflux.rocm
# jupyter/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.konflux.cuda
# jupyter/pytorch/ubi9-python-3.12/Dockerfile.konflux.cuda
# jupyter/rocm/pytorch/ubi9-python-3.12/Dockerfile.konflux.rocm
# jupyter/rocm/tensorflow/ubi9-python-3.12/Dockerfile.konflux.rocm
# jupyter/tensorflow/ubi9-python-3.12/Dockerfile.konflux.cuda
# jupyter/trustyai/ubi9-python-3.12/Dockerfile.konflux.cpu
# rstudio/rhel9-python-3.12/Dockerfile.cpu
# rstudio/rhel9-python-3.12/Dockerfile.cuda
# runtimes/minimal/ubi9-python-3.12/Dockerfile.konflux.cpu
# runtimes/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.konflux.cuda
# runtimes/pytorch/ubi9-python-3.12/Dockerfile.konflux.cuda
# runtimes/rocm-pytorch/ubi9-python-3.12/Dockerfile.konflux.rocm
# runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.konflux.rocm
# runtimes/tensorflow/ubi9-python-3.12/Dockerfile.konflux.cuda
ff96bb1 to
12dc5ea
Compare
|
/build-konflux |
…90x (already added for ppc64le before)
```
The headers or library files could not be found for zlib,
a required dependency when compiling Pillow from source.
Please see the install instructions at:
https://pillow.readthedocs.io/en/latest/installation/basic-installation.html
```
12dc5ea to
a734379
Compare
|
/build-konflux |
```
+ uv pip install /wheelsdir/pillow-11.3.0-cp312-cp312-manylinux_2_34_ppc64le.whl /wheelsdir/pyarrow-17.0.0-cp312-cp312-linux_ppc64le.whl
Using Python 3.12.9 environment at: /opt/app-root
× No solution found when resolving dependencies:
╰─▶ Because only numpy==2.3.4 is available and numpy==2.3.4 has no wheels
with a matching platform tag (e.g., `manylinux_2_34_ppc64le`), we can
conclude that numpy==2.3.4 cannot be used.
And because pyarrow==17.0.0 depends on numpy==2.3.4, we can conclude
that pyarrow==17.0.0 cannot be used.
And because only pyarrow==17.0.0 is available and you require pyarrow,
we can conclude that your requirements are unsatisfiable.
hint: Wheels are available for `numpy` (v2.3.4) on the following
platforms: `linux_aarch64`, `linux_x86_64`
subprocess exited with status 1
```
|
/build-konflux |
2 similar comments
|
/build-konflux |
|
/build-konflux |
… it causes build failure on ppc64le
```
+ uv pip install --offline --cache-dir /root/.cache/uv --requirements=./pylock.toml
warning: The `--pylock` option is experimental and may change without warning. Pass `--preview-features pylock` to disable this warning.
Using Python 3.12.9 environment at: /opt/app-root
× Failed to download `setuptools==80.9.0`
╰─▶ Network connectivity is disabled, but the
requested data wasn't found in the cache for:
`https://files.pythonhosted.org/packages/a3/dc/17031897dae0efacfea57dfd3a82fdd2a2aeb58e0ff71b77b87e44edc772/setuptools-80.9.0-py3-none-any.whl`
subprocess exited with status 1
```
554e24f to
e5ee8cb
Compare
|
/build-konflux |
|
@jiridanek: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/RHAIENG-948
https://issues.redhat.com/browse/RHAIENG-2114
https://redhat-internal.slack.com/archives/C07SBP17R7Z/p1763014884722089?thread_ts=1761667034.429529&cid=C07SBP17R7Z
Description
How Has This Been Tested?
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: