Skip to content

Expand cluster READ_COMMANDS with additional read-only commands and reorganize the list of commands by category #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2025
+75 −12
Merged

Expand cluster READ_COMMANDS with additional read-only commands and reorganize the list of commands by category #3845

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a78fa0
Updating the list with commands allowed to be sent to the read-only c…
petyaslavova Nov 14, 2025
542eef4
Applying review comment
petyaslavova Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 75 additions & 12 deletions redis/commands/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,20 +51,39 @@
# https://redis.io/commands
READ_COMMANDS = frozenset(
[
# Bit Operations
"BITCOUNT",
"BITFIELD_RO",
"BITPOS",
# Scripting
"EVAL_RO",
"EVALSHA_RO",
"EXISTS",
"GEODIST",
"GEOHASH",
"GEOPOS",
"GEORADIUS",
"GEORADIUSBYMEMBER",
"FCALL_RO",
# Key Operations
"DBSIZE",
"DIGEST",
"DUMP",
"EXISTS",
"EXPIRETIME",
"PEXPIRETIME",
"KEYS",
"SCAN",
"PTTL",
"RANDOMKEY",
"TTL",
"TYPE",
# String Operations
"GET",
"GETBIT",
"GETRANGE",
"MGET",
"STRLEN",
# Geo Operations
"GEODIST",
"GEOHASH",
"GEOPOS",
"GEOSEARCH",
# Hash Operations
"HEXISTS",
"HGET",
"HGETALL",
Expand All @@ -73,26 +92,70 @@
"HMGET",
"HSTRLEN",
"HVALS",
"KEYS",
"HRANDFIELD",
"HEXPIRETIME",
"HPEXPIRETIME",
"HTTL",
"HPTTL",
"HSCAN",
# List Operations
"LINDEX",
"LPOS",
"LLEN",
"LRANGE",
"MGET",
"PTTL",
"RANDOMKEY",
"LCS",
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCS (Longest Common Subsequence) is a string operation command that compares two string keys, not a list operation. According to the Redis documentation and the implementation in BasicKeyCommands class (not ListCommands), it should be categorized under "String Operations" instead of "List Operations".

Suggestion: Move LCS from line 106 to the String Operations section (after line 80).

Copilot uses AI. Check for mistakes.
# Set Operations
"SCARD",
"SDIFF",
"SINTER",
"SINTERCARD",
"SISMEMBER",
"SMISMEMBER",
"SMEMBERS",
"SRANDMEMBER",
"STRLEN",
"SUNION",
"TTL",
"SSCAN",
# Sorted Set Operations
"ZCARD",
"ZCOUNT",
"ZDIFF",
"ZINTER",
"ZINTERCARD",
"ZLEXCOUNT",
"ZMSCORE",
"ZRANDMEMBER",
"ZRANGE",
"ZRANGEBYLEX",
"ZRANGEBYSCORE",
"ZRANK",
"ZREVRANGE",
"ZREVRANGEBYLEX",
"ZREVRANGEBYSCORE",
"ZREVRANK",
"ZSCAN",
"ZSCORE",
"ZUNION",
# Stream Operations
"XLEN",
"XPENDING",
"XRANGE",
"XREAD",
"XREVRANGE",
# JSON Module
"JSON.ARRINDEX",
"JSON.ARRLEN",
"JSON.GET",
"JSON.MGET",
"JSON.OBJKEYS",
"JSON.OBJLEN",
"JSON.RESP",
"JSON.STRLEN",
"JSON.TYPE",
# RediSearch Module
"FT.EXPLAIN",
"FT.INFO",
"FT.PROFILE",
"FT.SEARCH",
]
)

Expand Down
Loading