Use MaxConnectionsError in the asyncio pool too
#3859
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns to the docs which indicate that this error type will be used when pool attempts to create more connections than are allowed. Fixes redis#3237
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
petyaslavova
approved these changes
Dec 1, 2025
Collaborator
petyaslavova
left a comment
petyaslavova
left a comment
There was a problem hiding this comment.
Hi @PeterJCLaw , thank you for your contribution!
The change LGTM.
It is a non-breaking change since the MaxConnectionsError is a subclass of ConnectionError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This aligns to the docs which indicate that this error type will be used when pool attempts to create more connections than are allowed.
Fixes #3237
Pull Request check-list
Please make sure to review and check all of these items:
Unknown
Docs already suggested this was the behaviour.