Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,7 @@
- stasundr
- stmtk1
- sukvvon
- sunnyraindy
- swalker326
- szhsin
- tanayv
Expand Down
2 changes: 1 addition & 1 deletion docs/how-to/navigation-blocking.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ If the user clicks "leave" then `blocker.proceed()` will proceed with the naviga

## 5. Reset the blocker when the action resolves

If the user doesn't click either "leave" or "stay here", then then submits the form, the blocker will still be active. Let's reset the blocker when the action resolves with an effect.
If the user doesn't click either "leave" or "stay here", then submits the form, the blocker will still be active. Let's reset the blocker when the action resolves with an effect.

```tsx filename=routes/contact.tsx
useEffect(() => {
Expand Down
2 changes: 1 addition & 1 deletion scripts/close-feature-pr.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
To align with our new [Open Governance](https://remix.run/blog/rr-governance) model, we are now asking that all new features go through the [Proposal/RFC process](https://github.com/remix-run/react-router/blob/main/GOVERNANCE.md#new-feature-process) and that we don't open PRs until a proposal has been been accepted and advanced to Stage 1.
To align with our new [Open Governance](https://remix.run/blog/rr-governance) model, we are now asking that all new features go through the [Proposal/RFC process](https://github.com/remix-run/react-router/blob/main/GOVERNANCE.md#new-feature-process) and that we don't open PRs until a proposal has been accepted and advanced to Stage 1.

If this feature doesn't have a Proposal, please [open one](https://github.com/remix-run/react-router/discussions/new?category=proposals) so we can evaluate/discuss the proposed feature. You can link to this PR as an example of a potential implementation and we can re-open it if the proposal advances.

Expand Down
2 changes: 1 addition & 1 deletion scripts/close-no-repro-issue.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ To align with our new [Open Governance](https://remix.run/blog/rr-governance) mo

To get this re-opened, please add a reproduction to the Issue description and tag `@brophdawg11` or `@brookslybrand` in a comment so we can re-open.

Or, if this was closed by mistake and there is a valid reproduction, please ensure that it is linked in the Issue description and and tag `@brophdawg11` or `@brookslybrand` in a comment so we can re-open.
Or, if this was closed by mistake and there is a valid reproduction, please ensure that it is linked in the Issue description and tag `@brophdawg11` or `@brookslybrand` in a comment so we can re-open.

If you have any questions, you can always reach out on [Discord](https://rmx.as/discord). Thanks again for providing feedback and helping us make React Router even better!