added ubuntu-22 compatibility #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
robertdebock
left a comment
robertdebock
left a comment
There was a problem hiding this comment.
Thanks for your input, one remark, for both changes. Let me know if you need help.
vars/main.yml
Outdated
| Ubuntu-17: /etc/php/7.1/fpm | ||
| Ubuntu-18: /etc/php/7.2/fpm | ||
| Ubuntu-19: /etc/php/7.2/fpm | ||
| Ubuntu-22: /etc/php/8.1/fpm |
Owner
There was a problem hiding this comment.
I'd rather have "Ubuntu" use /etc/php/8.1/fpm, like so:
Ubuntu-18: /etc/php/7.2/fpm
Ubuntu-20: /etc/php/7.4/fpm
Ubuntu: /etc/php/8.1/fpmThat structure hopefully works a little longer...
Author
|
Bookworm is failing because it also depends on PHP 8.1., I have added a commit that should also solve that. I was unsure if I should apply the same structure there because Bookworm is supposed to release next year. Isn't there a way to check the installed PHP Version instead of the system version? That would maybe solve some problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Describe the proposed change
Describe the change
Ubuntu 22 ships with PHP 8.1 by default, this adds the necessary directory and service
Testing
In case a feature was added, how were tests performed?
Local testing on Ubuntu 22.04 solves #1