Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 23, 2025

Addresses #950 by cleaning up a single launch file: example_1/rrbot.launch.py. This file has been improved to use a declarative programming style, as described by @emersonknapp at ROSCon, which can be viewed in the livestream at 6:10. A couple of local variables are needed for the Event Handlers, but all other unnecessary local variables are removed.

This change is a draft PR for feedback before rolling out changes to other launch files in other examples.


This is an automatic backport of pull request #959 done by Mergify.

(cherry picked from commit dd56581)

# Conflicts:
#	example_1/bringup/launch/rrbot.launch.py
@mergify
Copy link
Contributor Author

mergify bot commented Nov 23, 2025

Cherry-pick of dd56581 has failed:

On branch mergify/bp/humble/pr-959
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit dd56581.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   example_1/bringup/launch/rrbot.launch.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Nov 23, 2025
@christophfroehlich christophfroehlich merged commit 3ff218a into humble Nov 24, 2025
6 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-959 branch November 24, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants