-
Notifications
You must be signed in to change notification settings - Fork 427
Deprecate forward_command_controller specializations #1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
christophfroehlich
merged 7 commits into
master
from
deprecate/fwd_cmd_ctrl_specializations
Nov 19, 2025
Merged
Deprecate forward_command_controller specializations #1913
christophfroehlich
merged 7 commits into
master
from
deprecate/fwd_cmd_ctrl_specializations
Nov 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1913 +/- ##
=======================================
Coverage 85.13% 85.13%
=======================================
Files 144 144
Lines 13968 13968
Branches 1201 1201
=======================================
Hits 11891 11891
Misses 1670 1670
Partials 407 407
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
approved these changes
Nov 19, 2025
Member
saikishor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
check-prerelease-downstream
Runs the pre-release workflow with 1st level downstream dependencies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent PMC meeting we decided to deprecate the specializations for the sake of reducing duplicate code here in the repository.
Should we rename the package (can be done by adding a shim package with the old name and deprecation warnings) before adding another controller (twist_controller from #300)?
Slightly related to #157 (no need for controller specifications if we use standard Float64MultiArray message anyways)