Skip to content

Remove erase_all function #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Remove erase_all function #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17b6cc6
Remove unimplemented erase_all implementation
9names Feb 12, 2024
4ea2ecf
Rename rust-toolchain to rust-toolchain.toml
9names Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ version = "0.1.0"

[dependencies]
cortex-m = "0.7.0"
flash-algorithm = "0.4.0"
flash-algorithm = { version = "0.4.0", default-features = false, features = [
"panic-handler",
] }

# this lets you use `cargo fix`!
[[bin]]
Expand Down
1 change: 0 additions & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,4 @@ cat <<EOF
pc_uninit: $(sym UnInit)
pc_program_page: $(sym ProgramPage)
pc_erase_sector: $(sym EraseSector)
pc_erase_all: $(sym EraseChip)
EOF
0 rust-toolchain → rust-toolchain.toml
View file
Open in desktop
File renamed without changes.
5 changes: 0 additions & 5 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,6 @@ impl FlashAlgorithm for RP2040Algo {
Ok(Self { funcs })
}

fn erase_all(&mut self) -> Result<(), ErrorCode> {
// todo
Err(ErrorCode::new(0x70d0).unwrap())
}

fn erase_sector(&mut self, addr: u32) -> Result<(), ErrorCode> {
(self.funcs.flash_range_erase)(
addr - FlashDevice.dev_addr,
Expand Down