Enhances RSpec/MultipleExpectations message to suggest aggregate_failure

CHANGELOG.md

@@ -8,6 +8,7 @@
 - Fix a false positive for `RSpec/ReceiveNever` cop when `allow(...).to receive(...).never`. ([@ydah])
 - Fix detection of nameless doubles with methods in `RSpec/VerifiedDoubles`. ([@ushi-as])
 - Improve an offense message for `RSpec/RepeatedExample` cop. ([@ydah])
+- Improve `RSpec/MultipleExpectations` message to suggest using `aggregate_failures`. ([@svgr-slth])
 - Let `RSpec/SpecFilePathFormat` leverage ActiveSupport inflections when configured. ([@corsonknowles], [@bquorning])
 
 ## 3.7.0 (2025-09-01)

lib/rubocop/cop/rspec/multiple_expectations.rb

@@ -67,7 +67,8 @@ module RSpec
       #   end
       #
       class MultipleExpectations < Base
-        MSG = 'Example has too many expectations [%<total>d/%<max>d].'
+        MSG = 'Example has too many expectations [%<total>d/%<max>d]. ' \
+              'Consider using `aggregate_failures` if these expectations are logically related.'
 
         ANYTHING = ->(_node) { true }
         TRUE_NODE = lambda(&:true_type?)

spec/rubocop/cop/rspec/multiple_expectations_spec.rb

@@ -8,7 +8,7 @@
       expect_offense(<<~RUBY)
         describe Foo do
           it 'uses expect twice' do
-          ^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1].
+          ^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1]. Consider using `aggregate_failures` if these expectations are logically related.
             expect(foo).to eq(bar)
             expect(baz).to eq(bar)
           end
@@ -34,7 +34,7 @@
       expect_offense(<<~RUBY)
         describe Foo do
           it 'uses expect_any_instance_of twice' do
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1].
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1]. Consider using `aggregate_failures` if these expectations are logically related.
             expect_any_instance_of(Foo).to receive(:bar)
             expect_any_instance_of(Foo).to receive(:baz)
           end
@@ -46,7 +46,7 @@
       expect_offense(<<~RUBY)
         describe Foo do
           it 'uses expect_any_instance_of twice' do
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1].
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1]. Consider using `aggregate_failures` if these expectations are logically related.
             is_expected.to receive(:bar)
             is_expected.to receive(:baz)
           end
@@ -58,7 +58,7 @@
       expect_offense(<<~RUBY)
         describe Foo do
           it 'uses expect with block twice' do
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1].
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1]. Consider using `aggregate_failures` if these expectations are logically related.
             expect { something }.to change(Foo.count)
             expect { something }.to change(Bar.count)
           end
@@ -83,7 +83,7 @@
       expect_offense(<<~RUBY)
         describe Foo do
           it 'has multiple aggregate_failures calls' do
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1].
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1]. Consider using `aggregate_failures` if these expectations are logically related.
             aggregate_failures do
             end
             aggregate_failures do
@@ -143,7 +143,7 @@
       expect_offense(<<~RUBY)
         describe Foo, aggregate_failures: true do
           it 'uses expect twice', aggregate_failures: false do
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1].
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1]. Consider using `aggregate_failures` if these expectations are logically related.
             expect(foo).to eq(bar)
             expect(baz).to eq(bar)
           end
@@ -155,7 +155,7 @@
       expect_offense(<<~RUBY)
         describe Foo do
           it 'uses expect twice', aggregate_failures: false do
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1].
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1]. Consider using `aggregate_failures` if these expectations are logically related.
             expect(foo).to eq(bar)
             expect(baz).to eq(bar)
           end
@@ -167,7 +167,7 @@
       expect_offense(<<~RUBY)
         describe Foo, aggregate_failures: false do
           it 'uses expect twice' do
-          ^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1].
+          ^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1]. Consider using `aggregate_failures` if these expectations are logically related.
             expect(foo).to eq(bar)
             expect(baz).to eq(bar)
           end
@@ -179,7 +179,7 @@
       expect_offense(<<~RUBY)
         describe Foo do
           it 'uses expect twice' do
-          ^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1].
+          ^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1]. Consider using `aggregate_failures` if these expectations are logically related.
             expect(foo).to eq(bar)
             expect(baz).to eq(bar)
           end
@@ -228,7 +228,7 @@
       expect_offense(<<~RUBY)
         describe Foo do
           it 'uses expect three times' do
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [3/2].
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [3/2]. Consider using `aggregate_failures` if these expectations are logically related.
             expect(foo).to eq(bar)
             expect(baz).to eq(bar)
             expect(qux).to eq(bar)