Skip to content

Conversation

@1abhishekpandey
Copy link
Contributor

@1abhishekpandey 1abhishekpandey commented Nov 27, 2025

Description

  • Bump Braze Android and iOS SDK minimum version to the latest.

Summary by CodeRabbit

  • Chores
    • Updated Braze integration dependencies for Android and iOS platforms to improve compatibility and support for newer versions.

✏️ Tip: You can customize this high-level summary in your review settings.

🔒 Scanned for secrets using gitleaks 8.28.0
🔒 Scanned for secrets using gitleaks 8.28.0
@1abhishekpandey 1abhishekpandey self-assigned this Nov 27, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 27, 2025

📝 Walkthrough

Walkthrough

Updates Braze integration dependencies for Flutter SDK across platforms: Android Gradle dependency bumped from version range [2.0.0,3.0.0) to [2.1.0,3.0.0), and iOS podspec Rudder-Braze dependency updated from ~> 4.0 to ~> 4.2. No logic or configuration flow changes.

Changes

Cohort / File(s) Change summary
Braze Integration Dependency Upgrades
packages/integrations/rudder_integration_braze_flutter/android/build.gradle, packages/integrations/rudder_integration_braze_flutter/ios/rudder_integration_braze_flutter.podspec
Updated Braze integration dependencies to newer versions: Android minimum version increased from 2.0.0 to 2.1.0; iOS Rudder-Braze constraint relaxed from ~> 4.0 to ~> 4.2.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Simple dependency version updates with no logic changes
  • Verify compatibility of new versions (2.1.0 for Android, 4.2 for iOS)
  • Confirm version constraints align with SDK compatibility requirements

Possibly related PRs

Suggested reviewers

  • ChryssaAliferi
  • vgupta98

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: bumping both Braze Android and iOS SDK minimum versions, which aligns with the actual dependency version updates in both build.gradle and podspec files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/sdk-4144-flutter-update-the-minimum-version-of-the-braze-android-and

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d83d626 and 809f8e3.

📒 Files selected for processing (2)
  • packages/integrations/rudder_integration_braze_flutter/android/build.gradle (1 hunks)
  • packages/integrations/rudder_integration_braze_flutter/ios/rudder_integration_braze_flutter.podspec (1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: 1abhishekpandey
Repo: rudderlabs/rudder-sdk-flutter PR: 254
File: example/ios/Runner.xcodeproj/project.pbxproj:0-0
Timestamp: 2025-08-26T16:08:21.627Z
Learning: In the rudder-sdk-flutter project, the example iOS app deployment target and core SDK deployment target serve different purposes and don't need to be aligned. The example app can target newer iOS versions (like 13.0) for demonstration purposes, while the core SDK maintains broader compatibility (like 12.0) for wider adoption.
📚 Learning: 2025-08-26T16:08:21.627Z
Learnt from: 1abhishekpandey
Repo: rudderlabs/rudder-sdk-flutter PR: 254
File: example/ios/Runner.xcodeproj/project.pbxproj:0-0
Timestamp: 2025-08-26T16:08:21.627Z
Learning: In the rudder-sdk-flutter project, the example iOS app deployment target and core SDK deployment target serve different purposes and don't need to be aligned. The example app can target newer iOS versions (like 13.0) for demonstration purposes, while the core SDK maintains broader compatibility (like 12.0) for wider adoption.

Applied to files:

  • packages/integrations/rudder_integration_braze_flutter/ios/rudder_integration_braze_flutter.podspec
📚 Learning: 2025-08-26T16:07:06.160Z
Learnt from: 1abhishekpandey
Repo: rudderlabs/rudder-sdk-flutter PR: 254
File: packages/plugins/rudder_plugin_ios/ios/rudder_plugin_ios/Sources/rudder_plugin_ios/RudderSdkFlutterPlugin.m:0-0
Timestamp: 2025-08-26T16:07:06.160Z
Learning: In Flutter iOS plugins with Swift Package Manager support, the correct import pattern for plugin headers is to use relative paths like "./include/rudder_plugin_ios/RudderSdkFlutterPlugin.h" rather than header-search-path style imports, as per Flutter SPM documentation. UIKit imports are not needed as UIApplication symbols are available through transitive imports from Flutter framework headers.

Applied to files:

  • packages/integrations/rudder_integration_braze_flutter/ios/rudder_integration_braze_flutter.podspec
📚 Learning: 2025-08-26T12:56:18.523Z
Learnt from: 1abhishekpandey
Repo: rudderlabs/rudder-sdk-flutter PR: 253
File: packages/plugins/rudder_plugin_ios/example/lib/main.dart:1-1
Timestamp: 2025-08-26T12:56:18.523Z
Learning: In the rudder-sdk-flutter repository, broad `ignore_for_file` directives in example files may be necessary for melos commands to succeed during CI/CD, and should not be removed even if they impact pub.dev scores.

Applied to files:

  • packages/integrations/rudder_integration_braze_flutter/ios/rudder_integration_braze_flutter.podspec
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build & Code Quality Checks
  • GitHub Check: Unit Tests, Coverage & Sonar
🔇 Additional comments (2)
packages/integrations/rudder_integration_braze_flutter/android/build.gradle (1)

41-41: Braze Android integration bump looks consistent; verify against latest 2.x before release

The narrowed range to [2.1.0,3.0.0) keeps the existing semantics (floating within 2.x) while raising the minimum, which looks fine and consistent with the previous pattern. Please ensure CI and the sample app are exercised against the newest 2.x Braze artifact picked up by this range before merging.

packages/integrations/rudder_integration_braze_flutter/ios/rudder_integration_braze_flutter.podspec (1)

21-21: Rudder-Braze iOS bump is straightforward; confirm platform and API compatibility

Updating to Rudder-Braze ~> 4.2 while keeping the plugin’s iOS platform at 13.0 looks reasonable and keeps you on the 4.x line. Please run pod lib lint rudder_integration_braze_flutter.podspec and verify that 4.2+ still supports iOS 13.0 and the integration APIs you use, adjusting only the core SDK’s target if needed (the example app can remain higher if desired, based on learnings).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant