improve archive index locking #3066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
Member
Author
|
( CI failures because cloudflare is down) |
GuillaumeGomez
approved these changes
Dec 5, 2025
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until there is an automation I regularly remove the local archive file cache. #2971 was a first step towards building that automated cleanup job.
But this time this cleaning actually lead to docs.rs being down.
I couldn't really reproduce it locally, but IMO the reason is likely my locking structure, most likely the
.writelocks queueing up when the local cache is empty.The optimization here is: only use a lock to block for writes.
potential reads just wait until the file exists if there is already a writer downloading the index.
Also we treat broken index as "missing index", so hopefully won't have any problems.
Another optimization is that I pre-allocate the dashmap, since we know we'll add a bunch of entries.