-
Notifications
You must be signed in to change notification settings - Fork 1.2k
cygwin: Add missing utmp/x.h, grp.h, and stdio.h interfaces
#4827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
cygwin: Add missing utmp/x.h, grp.h, and stdio.h interfaces
#4827
Conversation
|
I don't think I touched MacOS, so I'm going to assume the fail is not due to my changes. I don't have hardware to test locally either... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes themselves LGTM, thank you for including links. A request for history though - could you squash the last two commits and make the commit message something like "cygwin: Add missing utmp/x.h, grp.h, and stdio.h interfaces"? We use cherry picks here so it's nice if the log is a bit more specific than "cygwin stuff" :)
(Feel free to just paste the great PR description/sources you have into the commit message, that would be awesome. We don't squash+merge because you can't choose the strategy with merge queues.)
|
Reminder, once the PR becomes ready for a review, use |
utmp/x.h, grp.h, and stdio.h interfaces
|
Cc also platform maintainer @Berrysoft |
Berrysoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked the changes and verified that they match the cygwin headers.
These constants and functions are required for building uutils-coreutils for Cygwin. Sources: https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/winsup/cygwin/include/cygwin/config.h#L50 https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/newlib/libc/include/stdio.h#L138-L139 https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/winsup/cygwin/include/cygwin/utmp.h#L20-L33 https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/winsup/cygwin/include/utmpx.h#L21-L32 https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/newlib/libc/include/stdio.h#L120-L122 https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/newlib/libc/include/grp.h#L64-L65 https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/winsup/cygwin/include/utmpx.h#L21-L32 https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/winsup/cygwin/include/utmpx.h#L42-L49
38f543e to
a8b347f
Compare
|
@tgross35 I have squashed the last 2 commits as requested. |
|
@rustbot ready |
Description
These constants and functions are required for building uutils-coreutils for Cygwin.
I'm not sure what the logic is on where things are placed, I just made it work. Additionally, I can't figure out how the tests work to fix it, but it's functional enough to unblock my immediate needs. Hopefully someone can give me guidance on how to clean up the changes and fix the tests?
Sources
https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/winsup/cygwin/include/cygwin/config.h#L50
https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/newlib/libc/include/stdio.h#L138-L139
https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/winsup/cygwin/include/cygwin/utmp.h#L20-L33
https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/winsup/cygwin/include/utmpx.h#L21-L32
https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/newlib/libc/include/stdio.h#L120-L122
https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/newlib/libc/include/grp.h#L64-L65
https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/winsup/cygwin/include/utmpx.h#L21-L32
https://github.com/msys2/msys2-runtime/blob/msys2-3.6.5/winsup/cygwin/include/utmpx.h#L42-L49
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated