Add section on expansion-time (early) name resolution #2055
Conversation
|
Thanks for posting. Lot of good here. The main thing I'd suggest, by way of helping to sharpen this up, would be to try to write a concise example after each claim, in as many cases as that might make sense, that demonstrates that the claim is true (and would not pass if the claim were false). Aside from the intrinsic benefit of having such examples, I think this might help to focus the text on the language-level effects. (It's not surprising, given the good research you've been doing, that some bits of this currently have some "description of the implementation" flavor.) |
yaahc
left a comment
yaahc
left a comment
There was a problem hiding this comment.
a fair number of comments are also contained inline in the documents
src/names/name-resolution.md
Outdated
| * .visitation-order | ||
| * derive helpers | ||
| * not visited when resolving derive macros in the parent scope (starting scope) | ||
| * derive helpers compat |
There was a problem hiding this comment.
Same concern as above about this being deprecated and removed next year.
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-author
|
@ehuss and I are looking at this together on the lang-docs office hours call, and we just wanted to express our appreciation to @petrochenkov for having been so responsive with @yaahc on working out the details here. This is a chapter that we've long wanted to exist, and we're thrilled and appreciative that @yaahc is digging in to shape this up. |
yaahc
force-pushed
the
name-res
branch
6 times, most recently
from
5397d08 to
1bd3afe
Compare
yaahc
force-pushed
the
name-res
branch
9 times, most recently
from
80fd707 to
570bedd
Compare
yaahc
force-pushed
the
name-res
branch
2 times, most recently
from
08596c4 to
dceb962
Compare
yaahc
force-pushed
the
name-res
branch
4 times, most recently
from
8a0b641 to
66899c6
Compare
|
Thanks to @yaahc for joining us on the lang-docs office hours today to speedrun many revisions to this chapter, which is really shaping up. |
Add test for derive helper compat collisions Resolves rust-lang/reference#2055 (comment) r? `@petrochenkov`
Add test for derive helper compat collisions Resolves rust-lang/reference#2055 (comment) r? `@petrochenkov`
Add test for derive helper compat collisions Resolves rust-lang/reference#2055 (comment) r? `@petrochenkov`
yaahc
force-pushed
the
name-res
branch
2 times, most recently
from
7751947 to
fb4fee6
Compare
This comment has been minimized.
This comment has been minimized.
yaahc
force-pushed
the
name-res
branch
4 times, most recently
from
8da1fb7 to
c96ed3f
Compare
Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com> Co-authored-by: Eric Huss <eric@huss.org> Co-authored-by: Tshepang Mbambo <hopsi@tuta.io>
Co-authored-by: Eric Huss <eric@huss.org> Co-authored-by: TC
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
7 participants
currently mostly a skeleton of a draft so we can collaboratively massage it into shape more easily before filling in with proper reference verbiage.
hoping to take a significant chunk out of #568