Skip to content

Conversation

@leftmostcat
Copy link

Document panics in String and Vec due to capacity overflowing isize::MAX. Correct outdated claims of usize::MAX limit.

Fixes #148598.

Ping @lolbinarycat

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@leftmostcat
Copy link
Author

At a glance, the build failures appear to be related to CI setup and not to these changes.

@lolbinarycat
Copy link
Contributor

CI is currently broken, it should be fixed once #148665 is merged.

@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

String methods do not acknowladge isize::MAX limit like Vec methods do

5 participants