Skip to content

Avoid infinite cycle in coerce_unsized_old_solver when encountering invalid recursive struct definition #148677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid infinite cycle in coerce_unsized_old_solver when encountering invalid recursive struct definition #148677

wants to merge 1 commit into from
+48 −1

Conversation

@estebank
Copy link
Contributor

@estebank estebank commented Nov 7, 2025 •
edited by rustbot
Loading

If an obligation's nested obligations expands to itself, do not add it to the working queue.

Fix #148653.

@estebank
Avoid infinite cycle in coerce_unsized_old_solver when encountering…
d199424 
… invalid recursive struct definition

If an obligation's nested obligations expands to itself, do not add it to the working queue.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2025

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@estebank estebank mentioned this pull request Nov 7, 2025
Open
@estebank
Copy link
Contributor Author

estebank commented Nov 7, 2025 •
edited
Loading

There might be a better approach.

CC @lcnr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BoxyUwU BoxyUwU

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hang in custom Vec

3 participants

@estebank @rustbot @BoxyUwU