Skip to content

Merge E0412 into E0425 #148678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Merge E0412 into E0425 #148678

wants to merge 3 commits into from
+555 −626

Conversation

@xonx4l
Copy link
Contributor

@xonx4l xonx4l commented Nov 7, 2025 •
edited by jieyouxu
Loading

This PR merge E0412 into E0425 as both mean the same thing to users ,as discussed in #148558.

@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Nov 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

mu001999
mu001999 reviewed Nov 8, 2025
View reviewed changes
compiler/rustc_resolve/src/late.rs
// Thus (since we're in expression-position at this point), not to
// confuse the user, we want to keep the *message* from E0433 (so
// `parent_err`), but we want *hints* from E0412 (so `err`).
// `parent_err`), but we want *hints* from the unified E0425 (so `err`).
Copy link
Contributor

@mu001999 mu001999 Nov 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just E0425 here

mu001999
mu001999 reviewed Nov 8, 2025
View reviewed changes
compiler/rustc_error_codes/src/error_codes/E0412.md
@@ -1,64 +1,6 @@
A used type name is not in scope.
This error code is no longer emitted by the compiler.
Copy link
Contributor

@mu001999 mu001999 Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add note on the top is good enough, see E0001.md for an example.

@jieyouxu
Copy link
Member

jieyouxu commented Nov 8, 2025

@rustbot reroll

@rustbot rustbot assigned madsmtm and unassigned jieyouxu Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mu001999 mu001999 mu001999 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@madsmtm madsmtm

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xonx4l @rustbot @jieyouxu @mu001999 @madsmtm