Skip to content

Recover [T: N] as [T; N] #148680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Recover [T: N] as [T; N] #148680

wants to merge 1 commit into from

Conversation

@ShE3py
Copy link
Contributor

@ShE3py ShE3py commented Nov 8, 2025 •
edited by rustbot
Loading

; is similar and (keyboard-wise) next to :, so a verbose suggestion may help to see the difference.

Parent PR: #143905

@rustbot label +A-parser +A-array +A-diagnostics +A-suggestion-diagnostics +D-papercut

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-array Area: `[T; N]` A-diagnostics Area: Messages for errors, warnings, and lints A-parser Area: The lexing & parsing of Rust source code to an AST A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-papercut Diagnostics: An error or lint that needs small tweaks. labels Nov 8, 2025
ShE3py
ShE3py commented Nov 8, 2025
View reviewed changes
compiler/rustc_parse/src/parser/ty.rs
let mut err =
self.dcx().struct_span_err(span, format!("expected `;` or `]`, found {}", token_descr));
err.span_label(span, "expected `;` or `]`");
err.note("you might have meant to write a slice or array type");
Copy link
Contributor Author

@ShE3py ShE3py Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is redondant with the suggestion, and otherwise not really helpful.

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Nov 8, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 8, 2025

📌 Commit d1052e4 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-array Area: `[T; N]` A-diagnostics Area: Messages for errors, warnings, and lints A-parser Area: The lexing & parsing of Rust source code to an AST A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-papercut Diagnostics: An error or lint that needs small tweaks. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ShE3py @rustbot @JonathanBrouwer @bors @wesleywiser