std: use nonpoison::Mutex for all internal mutexes
#148689
Open
+56
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
O-unix
joboet
commented
Nov 8, 2025
Comment on lines
+438
to
+445
| #[stable(feature = "catch_unwind", since = "1.9.0")] | ||
| impl UnwindSafe for Stdin {} | ||
|
|
||
| #[stable(feature = "catch_unwind", since = "1.9.0")] | ||
| impl RefUnwindSafe for Stdin {} | ||
|
|
Member
Author
There was a problem hiding this comment.
The manual implementation is necessary to avoid a situation like #146087.
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
nonpoison-mutex-everywhere
branch
from
c5f4eac to
77d3da4
Compare
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
nonpoison-mutex-everywhere
branch
from
77d3da4 to
d75cc3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the hopefully reasonable assumption that
std's code is bug-free, all of the mutexes switched here will never be poisoned. The only poisoning mutex left is the one used for output capturing, as that has subtle effects on what gets captured.