Clippy subtree update #148957

flip1995 · 2025-11-15T00:18:13Z

Their meanings, and the way they're handled in `get_attr`, are pretty similar

- Move it and its helper function `parse_attrs` together to the end of the file, because it's surprising to see front-and-center a struct that's only really used in one place (`cognitive_complexity`). - Avoid panic path in `LimitStack::limit` - Replace `assert` with `debug_assert` to avoid panics in release builds

Reduces code repetition

Now we don't touch, and thus don't break, whatever path `Rc`/`Arc` was specified with

…test` build

Move `unused_enumerate_index.rs` to `methods`.

Fix rust-lang/rust-clippy#14350 Co-authored-by: Timo <30553356+y21@users.noreply.github.com>

…dead Constify trait aliases Allow `const trait Foo = Bar + [const] Baz;` trait alias declarations. Their rules are the same as with super traits of const traits. So `[const] Baz` or `const Baz` is only required for `[const] Foo` or `const Foo` bounds respectively. tracking issue rust-lang#41517 (part of the general trait alias feature gate, but I can split it out into a separate const trait alias feature gate. I just assumed that const traits would stabilize before trait aliases, and we'd want to stabilize trait aliases together with const trait aliases at the same time) r? ``@compiler-errors`` ``@fee1-dead``

bors · 2025-11-15T12:37:20Z

📌 Commit 84af28b has been approved by Manishearth

It is now in the queue for this repository.

flip1995 · 2025-11-15T12:47:59Z

@bors p=0

Let's only bump priority once PR CI passes. This test is still failing for me locally for whatever reason.

flip1995 · 2025-11-15T13:34:44Z

@bors p=1 PR CI passed.

bors · 2025-11-15T16:03:46Z

⌛ Testing commit 84af28b with merge 0291100...

Clippy subtree update r? `@Manishearth`

madsmtm · 2025-11-15T16:57:00Z

@madsmtm could you take a look at the Cargo.lock update here, please? A bit surprising that Clippy just added the tikv allocator in Cargo.lock 🤔

Probably some sort of race between #146627 and when it was reverted in #148896?

I'm unsure of how exactly Josh subtrees work, but in this PR's current state, I fear that merging this is gonna re-introduce the perf regression for Clippy, so:
@bors r-

bors · 2025-11-15T19:14:43Z

☀️ Try build successful - checks-actions
Build commit: 0291100 (0291100d11327aa7f7500a03046e6fff90bbc5cb)

RalfJung · 2025-11-15T22:08:05Z

Yeah this apparently changes the version of tikv-jemalloc-sys for everything in the rustc workspace. Why that?

RalfJung · 2025-11-15T22:09:24Z

src/tools/clippy/Cargo.toml

 termize = "0.2"
 color-print = "0.3.4"
 anstream = "0.6.18"
+tikv-jemalloc-sys = { version = "0.6.1", optional = true, features = ['override_allocator_on_supported_platforms'] }


This should probably not say 0.6.1. This is what forces the version bump for everything in the repo, and that's really not something we should do in a subtree sync PR.

Ah, I messed up when resolving conflicts. This was it. I left Cargo.toml untouched and reverted the Cargo.lock changes.

Shouldn't have done the sync at 1am...

…ubtree-update

flip1995 · 2025-11-16T14:21:38Z

@bors r=Manishearth

bors · 2025-11-16T14:21:41Z

📌 Commit b006b3d has been approved by Manishearth

It is now in the queue for this repository.

bors · 2025-11-16T16:43:59Z

⌛ Testing commit b006b3d with merge cc57d9a...

bors · 2025-11-16T19:56:00Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing cc57d9a to main...

github-actions · 2025-11-16T19:59:03Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e92ffc3 (parent) -> cc57d9a (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard cc57d9a2ab7f665dbf4c36c126188889bb47886a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 3923.1s -> 3434.8s (-12.4%)
x86_64-gnu-gcc: 2769.4s -> 3086.0s (+11.4%)
x86_64-gnu-aux: 6660.8s -> 5928.9s (-11.0%)
i686-msvc-2: 7379.7s -> 8158.7s (+10.6%)
x86_64-gnu-llvm-20: 2461.0s -> 2222.6s (-9.7%)
aarch64-gnu-llvm-20-2: 2195.9s -> 2396.4s (+9.1%)
x86_64-gnu: 7038.7s -> 6398.4s (-9.1%)
x86_64-gnu-llvm-20-1: 3231.0s -> 2978.2s (-7.8%)
pr-check-1: 1503.1s -> 1391.1s (-7.4%)
dist-x86_64-mingw: 8656.1s -> 9281.6s (+7.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-16T21:16:55Z

Finished benchmarking commit (cc57d9a): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	1.3%	[1.3%, 1.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.3%	[1.3%, 1.3%]	1

Max RSS (memory usage)

Results (primary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.8%	[3.8%, 3.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[-3.0%, 3.8%]	2

Cycles

Results (primary 2.5%, secondary -3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	2.5%	[2.5%, 2.5%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.813s -> 473.602s (0.59%)
Artifact size: 388.74 MiB -> 388.70 MiB (-0.01%)

…nishearth Clippy subtree update r? `@Manishearth`

profetia and others added 30 commits October 11, 2025 03:02

fix: match_single_binding suggests wrongly inside tuple

f39ed7a

clean-up

e1ed9ec

merge DeprecationStatus::{Replaced,Deprecated}

c3257f4

Their meanings, and the way they're handled in `get_attr`, are pretty similar

give functions more descriptive names, add docs

e55b435

clean-up a bit

1aa5b99

fix: return true everywhere we emit the lint

12426b6

refactor: also handle Vec in match_buffer_type

6aecd1f

Reduces code repetition

fix: make the suggestion apply only to the inner type

3714236

Now we don't touch, and thus don't break, whatever path `Rc`/`Arc` was specified with

refactor: reduce code duplication further

f2e6667

clean-up

a4924e2

feat(ok_expect): add autofix

9816437

fix: match_single_binding misses curlies for const

dd943fd

Fix spacing typo in new inefficient_to_string info

2fe16a5

fix: missing_inline_in_public_items fail to fulfill expect in `--…

b42f87c

…test` build

refactor ub_checks and contract_checks to share logic

ff9a175

clean-up

892cb18

introduce as_some_pattern

59890a9

introduce as_some_expr, is_none_expr

605cc87

Consider type conversion that won't overflow

b7f9216

unused_enumerate_index: move to loops lint pass

bd22913

Move `unused_enumerate_index.rs` to `methods`.

Refactor unused_enumerate_index.

ce6f8bc

Trait aliases are rare large ast nodes, box them

07b6b32

extend needless_collect

6d7072b

Fix rust-lang/rust-clippy#14350 Co-authored-by: Timo <30553356+y21@users.noreply.github.com>

Implement pattern matching for &pin mut|const T

42f074d

Rename #[pin_project] to #[pin_v2] to avoid naming conflicts

8992878

fix: Only special case single line item attribute suggestions

0fd7406

Constify trait aliases

3f5ea6b

misc: test cases with escaping are mostly autofixable now

938dd5f

bors added a commit that referenced this pull request Nov 15, 2025

Auto merge of #148957 - flip1995:clippy-subtree-update, r=Manishearth

0291100

Clippy subtree update r? `@Manishearth`

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 15, 2025

madsmtm mentioned this pull request Nov 15, 2025

Simplify jemalloc setup (without perf regression) #148925

Open

RalfJung reviewed Nov 15, 2025

View reviewed changes

Merge commit '62589a21d351f63d77dcd173c31107e9f1d06328' into clippy-s…

b006b3d

…ubtree-update

flip1995 force-pushed the clippy-subtree-update branch from 84af28b to b006b3d Compare November 16, 2025 14:20

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 16, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 16, 2025

bors merged commit cc57d9a into rust-lang:main Nov 16, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 16, 2025

This was referenced Nov 16, 2025

Allow initializing NonZero with literals #143594

Draft

Limited nonzero coercion #143629

Draft

Emit error when using path-segment keyword as cfg pred #146978

Open

Replace OffsetOf by an actual sum of calls to intrinsic. #148151

Merged

Muscraft pushed a commit to Muscraft/rust that referenced this pull request Nov 17, 2025

Auto merge of rust-lang#148957 - flip1995:clippy-subtree-update, r=Ma…

43b97a2

…nishearth Clippy subtree update r? `@Manishearth`

Clippy subtree update #148957

Clippy subtree update #148957

Uh oh!

Conversation

flip1995 commented Nov 15, 2025

Uh oh!

bors commented Nov 15, 2025

Uh oh!

flip1995 commented Nov 15, 2025

Uh oh!

flip1995 commented Nov 15, 2025

Uh oh!

bors commented Nov 15, 2025

Uh oh!

madsmtm commented Nov 15, 2025

Uh oh!

bors commented Nov 15, 2025

Uh oh!

RalfJung commented Nov 15, 2025

Uh oh!

RalfJung Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

flip1995 Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flip1995 commented Nov 16, 2025

Uh oh!

bors commented Nov 16, 2025

Uh oh!

bors commented Nov 16, 2025

Uh oh!

bors commented Nov 16, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 16, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Nov 16, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

34 participants

flip1995 Nov 16, 2025 •

edited

Loading