-
Notifications
You must be signed in to change notification settings - Fork 987
Unpack progress #4594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpack progress #4594
Conversation
|
After testing the changes, it seems that the ticking speed for the unpacking phase is so high that it feels a bit disconcerting. Moreover, I would like to ask whether this change is a step toward achieving concurrent downloads & installs (without spawning an additional thread). I think that making |
|
@FranciscoTGouveia In the current stable version we actually have progress reporting for unpacking as well, however it's behind a 1-second timeout so no one actually sees it except for the docs component. Thus, I think your concern is reasonable, and even though it's probably great for @djc to restore that behavior here, it might be worth it to make it closer to the original in terms of lowering the number of ticks indeed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested locally. The code looks okay but I share @FranciscoTGouveia's concern: it looks like the tick frequency is way too high...
|
Changed it to display a progress bar while unpacking. See the movie in the PR description (which also includes #4602). |
cc @FranciscoTGouveia
unpack-progress.mov