Add Pixel struct
#289
Open
Add Pixel struct
#289
+353
−165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
madsmtm/pixel
branch
from
28bdba2 to
be55109
Compare
madsmtm
commented
Nov 23, 2025
Comment on lines
+95
to
+99
| /// The alpha component. | ||
| /// | ||
| /// `0xff` here means opaque, whereas `0` means transparent. | ||
| /// | ||
| /// NOTE: Transparency is not yet supported, see [#17], so this doesn't actually do anything. | ||
| /// | ||
| /// [#17]: https://github.com/rust-windowing/softbuffer/issues/17 | ||
| pub(crate) a: u8, |
Member
Author
There was a problem hiding this comment.
We could leave this out, but:
- There are backends that want to read this, such as the Web backend, and leaving it as padding in the struct would cause that to read uninitialized bytes instead.
- It'll be useful in moving towards Transparency #17 with less of a breaking change.
The downside of course is that struct initialization syntax is unavailable (at least until we expose this).
This is much more intuitive to use than manually bit-packing into a u32. The format is RGBX on WASM and Android and BGRX elsewhere. This should allow avoiding needless copying on these platforms.
madsmtm
force-pushed
the
madsmtm/pixel
branch
from
be55109 to
7c3eba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is much easier to get right than manually bit-packing into a
u32.The format is RGBX on WASM (and TODO Android) and BGRX elsewhere, which should also allow avoiding needless copying on WASM. This should either fix or allow fixing #207.
See also discussion in #98. This is not a full solution to pixel formats such as proposed by #186 and #241, but I believe it's an improvement we can more easily make in the meantime, and if nothing else it should at least be a stepping stone in allowing us to figure out what we do want.
Fixes #109.
Tested on: