-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Compute the right span for abstract error messages #23853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Future work: should we use the same source position (with the complete span) for other messages in |
|
Note: there is an existing scala3/compiler/src/dotty/tools/dotc/ast/Trees.scala Lines 380 to 389 in fe457a3
However it seems we can't use it because we don't have a tree for the class when doing the checks in |
Co-authored-by: HarrisL2 <harris.yh.lau@gmail.com> Co-authored-by: kalil0321 <kalil.bouzigues@gmail.com>
tgodzik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes scala#22941. Done during the compiler spree of September 1st, 2025. Co-authored-by: HarrisL2 <harris.yh.lau@gmail.com> Co-authored-by: kalil0321 <kalil.bouzigues@gmail.com> [Cherry-picked 13d4963]
Fixes #22941. Done during the compiler spree of September 1st, 2025.