-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Reintroduce reflective REPL pprint call. #24353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The class name changed, but the reflective call is still necessary for deeply nested objects to be formatted correctly.
|
|
Looks good to me, need this to merge first so I can rebase #24298 on top |
|
@bishabosha how are you testing this? |
Scala CLI v1.10.0 handles the new REPL artifact. |
|
I test by publishing the binary locally with java -cp $(cs fetch -p org.scala-lang:scala3-repl_3:3.8.0-RC1-bin-SNAPSHOT) dotty.tools.repl.Main -cp $(cs fetch -p org.scala-lang:scala3-repl_3:3.8.0-RC1-bin-SNAPSHOT)although @hamzaremmal is working on either an alternative or replacement PR that should hide pprint from visible class path I think |
|
@Gedochao I'm getting an error running |
|
same failure happens on d47c0c6 as well, so even a clean |
I've been talking with Jamie about this PR offline and it is just lacking a comment that explains how all of this works. |
The class name changed, but the reflective call is still necessary for deeply nested objects to be formatted correctly.
@tgodzik @Gedochao for 3.8 backport recommendation
./cc @lihaoyi