Add support for WinDivert packet capture engine #2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2019 +/- ##
=======================================
Coverage 83.47% 83.47%
=======================================
Files 311 312 +1
Lines 54574 54588 +14
Branches 11514 11522 +8
=======================================
+ Hits 45553 45565 +12
+ Misses 7795 7765 -30
- Partials 1226 1258 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add missing doxygen documentation
seladb
changed the title
Dimi1010
reviewed
Nov 11, 2025
seladb
commented
Nov 13, 2025
| PTF_ASSERT_TRUE(sendURLRequest("www.google.com")); | ||
| // let the capture work for couple of seconds | ||
| totalSleepTime = incSleep(capturedPackets, 2, 7); | ||
| totalSleepTime = incSleep(capturedPackets, 2, 20); |
Owner
Author
There was a problem hiding this comment.
This test also failed in CI so I made it more robust
Comment on lines
+75
to
83
| parser.add_argument( | ||
| "--include-tests", | ||
| "-t", | ||
| type=str, | ||
| nargs="+", | ||
| default=[], | ||
| help="Pcap++ tests to include", | ||
| ) | ||
| parser.add_argument( |
Owner
Author
There was a problem hiding this comment.
This change was needed to support running only WinDivert tests in the windivert job in CI
Dimi1010
reviewed
Nov 13, 2025
Dimi1010
reviewed
Nov 13, 2025
Dimi1010
reviewed
Nov 13, 2025
Dimi1010
reviewed
Nov 13, 2025
seladb
changed the title
Dimi1010
reviewed
Nov 14, 2025
…and IWinDivertImplementation creates it
Dimi1010
reviewed
Nov 16, 2025
Dimi1010
reviewed
Nov 16, 2025
Dimi1010
reviewed
Nov 16, 2025
Dimi1010
reviewed
Nov 17, 2025
Dimi1010
reviewed
Nov 24, 2025
Dimi1010
reviewed
Nov 29, 2025
Dimi1010
reviewed
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates WinDivert as another packet capture engine in PcapPlusPlus, enabling packet capture/injection on Windows via the WinDivert driver.
What is WinDivert
WinDivert is an open-source Windows library (kernel + user-mode) that allows applications to intercept, modify, drop or inject network packets traversing the Windows network stack. It is designed for use cases such as packet sniffing, firewalling, NAT-/VPN-tunneling, loopback traffic inspection, etc.
Key features include:
Project Links
Testing
This PR includes basic tests for the
WinDivertDevice. However, it also adds a lightweight abstraction over the WinDivert API using internal interfaces. It enables testingWinDivertDevicelogic without the real driver by providing mock implementations. These mock tests aren't implemented in this PR, but can be added later.