Skip to content

Fix TraceId and SpanId with null value #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

Fix TraceId and SpanId with null value #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/Output/StandardColumnDataGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ public KeyValuePair<string, object> GetStandardColumnNameAndValue(StandardColumn
case StandardColumn.Level:
return new KeyValuePair<string, object>(_columnOptions.Level.ColumnName, _columnOptions.Level.StoreAsEnum ? (object)logEvent.Level : logEvent.Level.ToString());
case StandardColumn.TraceId:
return new KeyValuePair<string, object>(_columnOptions.TraceId.ColumnName, logEvent.TraceId.ToString());
return new KeyValuePair<string, object>(_columnOptions.TraceId.ColumnName, logEvent.TraceId?.ToString());
case StandardColumn.SpanId:
return new KeyValuePair<string, object>(_columnOptions.SpanId.ColumnName, logEvent.SpanId.ToString());
return new KeyValuePair<string, object>(_columnOptions.SpanId.ColumnName, logEvent.SpanId?.ToString());
case StandardColumn.TimeStamp:
return GetTimeStampStandardColumnNameAndValue(logEvent);
case StandardColumn.Exception:
Expand Down
38 changes: 38 additions & 0 deletions ...ilog.Sinks.MSSqlServer.Tests/Sinks/MSSqlServer/Output/StandardColumnDataGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,25 @@ public void GetStandardColumnNameAndValueForTraceIdReturnsLogLevelKeyValue()
Assert.Equal("34898a9020e0390190b0982370034f00", result.Value);
}

[Fact]
public void GetStandardColumnNameAndNullValueForTraceIdReturnsLogLevelKeyValue()
{
// Arrange
var traceId = default(ActivityTraceId);
var logEvent = new LogEvent(
new DateTimeOffset(2020, 1, 1, 0, 0, 0, 0, TimeSpan.Zero),
LogEventLevel.Debug, null, new MessageTemplate(new List<MessageTemplateToken>() { new TextToken("Test message") }),
new List<LogEventProperty>(), traceId, ActivitySpanId.CreateRandom());
SetupSut(new MSSqlServer.ColumnOptions(), CultureInfo.InvariantCulture);

// Act
var result = _sut.GetStandardColumnNameAndValue(StandardColumn.TraceId, logEvent);

// Assert
Assert.Equal("TraceId", result.Key);
Assert.Null(result.Value);
}

[Fact]
public void GetStandardColumnNameAndValueForSpanIdReturnsLogLevelKeyValue()
{
Expand All @@ -301,6 +320,25 @@ public void GetStandardColumnNameAndValueForSpanIdReturnsLogLevelKeyValue()
Assert.Equal("0390190b09823700", result.Value);
}

[Fact]
public void GetStandardColumnNameAndNullValueForSpanIdReturnsLogLevelKeyValue()
{
// Arrange
var spanId = default(ActivitySpanId);
var logEvent = new LogEvent(
new DateTimeOffset(2020, 1, 1, 0, 0, 0, 0, TimeSpan.Zero),
LogEventLevel.Debug, null, new MessageTemplate(new List<MessageTemplateToken>() { new TextToken("Test message") }),
new List<LogEventProperty>(), ActivityTraceId.CreateRandom(), spanId);
SetupSut(new MSSqlServer.ColumnOptions(), CultureInfo.InvariantCulture);

// Act
var result = _sut.GetStandardColumnNameAndValue(StandardColumn.SpanId, logEvent);

// Assert
Assert.Equal("SpanId", result.Key);
Assert.Null(result.Value);
}

[Fact]
public void GetStandardColumnNameAndValueForLogLevelReturnsLogLevelKeyValueAsEnum()
{
Expand Down
Loading