Refactor redisReceiver to eliminate global state and prevent memory leaks

react_on_rails_pro/packages/node-renderer/tests/redisClient.test.ts

@@ -0,0 +1,37 @@
+import { createClient } from 'redis';
+
+const redisClient = createClient({ url: process.env.REDIS_URL || 'redis://localhost:6379' });
+
+test('Redis client connects successfully', async () => {
+  await redisClient.connect();
+  expect(redisClient.isOpen).toBe(true);
+  await redisClient.quit();
+});
+
+test('calls connect after quit', async () => {
+  await redisClient.connect();
+  expect(redisClient.isOpen).toBe(true);
+  await redisClient.quit();
+
+  await redisClient.connect();
+  expect(redisClient.isOpen).toBe(true);
+  await redisClient.quit();
+});
+
+test('calls quit before connect is resolved', async () => {
+  const client = createClient({ url: process.env.REDIS_URL || 'redis://localhost:6379' });
+  const connectPromise = client.connect();
+  await client.quit();
+  await connectPromise;
+  expect(client.isOpen).toBe(false);
+});
+
+test('multiple connect calls', async () => {
+  const client = createClient({ url: process.env.REDIS_URL || 'redis://localhost:6379' });
+  const connectPromise1 = client.connect();
+  const connectPromise2 = client.connect();
+  await expect(connectPromise2).rejects.toThrow('Socket already opened');
+  await expect(connectPromise1).resolves.toMatchObject({});
+  expect(client.isOpen).toBe(true);
+  await client.quit();
+});

react_on_rails_pro/spec/dummy/client/app/components/ErrorComponent.tsx

@@ -7,6 +7,7 @@ const ErrorComponent = ({ error }: { error: Error }) => {
     <div>
       <h1>Error happened while rendering RSC Page</h1>
       <p>{error.message}</p>
+      <p>{error.stack}</p>
     </div>
   );
 };

react_on_rails_pro/spec/dummy/client/app/ror-auto-load-components/RSCPostsPageOverRedis.jsx

@@ -3,14 +3,14 @@ import RSCPostsPage from '../components/RSCPostsPage/Main';
 import { listenToRequestData } from '../utils/redisReceiver';
 
 const RSCPostsPageOverRedis = ({ requestId, ...props }, railsContext) => {
-  const { getValue, close } = listenToRequestData(requestId);
+  const { getValue, destroy } = listenToRequestData(requestId);
 
   const fetchPosts = () => getValue('posts');
   const fetchComments = (postId) => getValue(`comments:${postId}`);
   const fetchUser = (userId) => getValue(`user:${userId}`);
 
   if ('addPostSSRHook' in railsContext) {
-    railsContext.addPostSSRHook(close);
+    railsContext.addPostSSRHook(destroy);
   }
 
   return () => (

react_on_rails_pro/spec/dummy/client/app/ror-auto-load-components/RedisReceiver.jsx

@@ -34,10 +34,10 @@ const AsyncToggleContainer = async ({ children, childrenTitle, getValue }) => {
 };
 
 const RedisReceiver = ({ requestId, asyncToggleContainer }, railsContext) => {
-  const { getValue, close } = listenToRequestData(requestId);
+  const { getValue, destroy } = listenToRequestData(requestId);
 
   if ('addPostSSRHook' in railsContext) {
-    railsContext.addPostSSRHook(close);
+    railsContext.addPostSSRHook(destroy);
   }
 
   const UsedToggleContainer = asyncToggleContainer ? AsyncToggleContainer : ToggleContainer;