Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
035785c
Phase 5: Add Pro Node Renderer Package to workspace
justin808 Nov 20, 2025
f74c9b4
Update documentation formatting for Phase 5 completion
justin808 Nov 20, 2025
20256c8
Document Pro changelog rename in Phase 6
justin808 Nov 20, 2025
d00b759
Fix node-renderer TypeScript ESM compatibility and add missing depend…
justin808 Nov 20, 2025
1507c3c
Disable yarn cache for Node 22 in Pro CI to fix V8 crash
justin808 Nov 20, 2025
b0fd33f
Disable yarn cache for Node 22 in all remaining CI workflows
justin808 Nov 20, 2025
9fc6032
Update react_on_rails_pro build paths after node-renderer extraction
justin808 Nov 20, 2025
02cc336
Address code review feedback: workspace protocol and file organization
justin808 Nov 20, 2025
c2bd932
Improve build scripts and Node version pinning per code review
justin808 Nov 20, 2025
de899cd
Fix: Revert workspace protocol to version numbers for Yarn Classic
justin808 Nov 20, 2025
67064cf
Add knip configuration for node-renderer package
justin808 Nov 20, 2025
9906bf0
Remove invalid exports from react_on_rails_pro/package.json
justin808 Nov 20, 2025
2fe802c
Fix Jest configuration for monorepo node-renderer tests
justin808 Nov 20, 2025
ea3aa73
Fix node-renderer package.json and knip configuration
justin808 Nov 20, 2025
5af6e4b
Format: Apply Prettier to knip.ts entry points array
justin808 Nov 20, 2025
d586369
Restore original formatting for fixture files to preserve git history
github-actions[bot] Nov 20, 2025
db33c67
delete new node-renderer package.json
Judahmeek Nov 20, 2025
7e40160
move old RoR Pro to be node-renderer package.json to preserve history
Judahmeek Nov 20, 2025
e617564
update prepack script to support node-renderer
Judahmeek Nov 20, 2025
ff6a9ff
remove uneccessary devDependencies
Judahmeek Nov 20, 2025
40b7852
move preinstall script
Judahmeek Nov 20, 2025
9fde03c
don't use yalc in a yarn workspace
Judahmeek Nov 20, 2025
7624c85
prep for running yarn type-check
Judahmeek Nov 20, 2025
783599b
Fix TS errors
alexeyr Nov 20, 2025
d8ce039
Fix knip issues
alexeyr Nov 20, 2025
0643bc7
Fix paths in RORP Node Renderer package.json
alexeyr Nov 20, 2025
77098be
Fix additional Knip issues
alexeyr Nov 20, 2025
cd6aa9c
Remove many unused Knip ignores
alexeyr Nov 20, 2025
121765e
rebased on origin/justin808/monorepo-completion
Judahmeek Nov 20, 2025
85f1ab9
move prettier exclusions for node-renderer
Judahmeek Nov 20, 2025
3fdaaa4
remove unused coverage config for jest
Judahmeek Nov 20, 2025
d614c2e
resolve knip reports
Judahmeek Nov 20, 2025
62e47f6
move jest scripts to root
Judahmeek Nov 21, 2025
00b93a6
use file references instead of stale versions
Judahmeek Nov 21, 2025
f89de5a
any change to react-on-rails should trigger pro tests
Judahmeek Nov 21, 2025
dfa3b5d
use npm script instead of nps script for ci
Judahmeek Nov 21, 2025
a0dc1b4
misc changes
Judahmeek Nov 21, 2025
c9f1ef5
Fix: Update documentation paths and ESM imports
justin808 Nov 21, 2025
a5d4fbd
Add missing jest-junit dependency to node-renderer package
justin808 Nov 21, 2025
b59cbea
Fix jest-junit reporter error in CI (#ISSUE)
justin808 Nov 21, 2025
8e113b5
Add jest-junit to knip ignoreDependencies
justin808 Nov 21, 2025
dfb64c7
Fix jest-junit reporter error in CI (#ISSUE)
justin808 Nov 21, 2025
6275b14
Fix knip unused dependencies and package reference issues
justin808 Nov 21, 2025
14fe324
Fix workspace dependencies and build scripts
justin808 Nov 21, 2025
528c210
Fix workspace dependencies for Yarn Classic compatibility
justin808 Nov 21, 2025
abd1410
Add import/export rule to ESLint ignores for Pro package
justin808 Nov 21, 2025
33c4be2
Document workspace dependency testing requirements
justin808 Nov 21, 2025
39f6176
Fix check-typescript script to use workspace type-check scripts
justin808 Nov 21, 2025
e47252b
Update tests, workflows, and documentation for parameter order fix
justin808 Nov 21, 2025
4bc2c9e
Add CI change detection for node-renderer package
justin808 Nov 21, 2025
636f3c2
Add comprehensive CI failure analysis for PR #2069
justin808 Nov 22, 2025
f14376e
Document testing requirements for CI failure analysis and fixes
justin808 Nov 22, 2025
b4cb7e1
Address critical code review issues
justin808 Nov 22, 2025
4f793ca
Add guidance on using GH CLI to check if failures are pre-existing
justin808 Nov 22, 2025
7507ca6
Improve CI status checking guidance with timeline analysis
justin808 Nov 22, 2025
fb6ed24
Address code review feedback: fix CI paths and organize docs
justin808 Nov 22, 2025
28f98a7
Fix console replay double-wrapping bug and update Node.js version
justin808 Nov 22, 2025
e755780
Upgrade Capybara to 3.40.0 for Rack 3.2 compatibility
justin808 Nov 22, 2025
3c59f10
Update root Gemfile.lock after Capybara version constraint
justin808 Nov 22, 2025
76ff92b
Add PR splitting strategy documentation for complex CI failures
justin808 Nov 22, 2025
189f414
Update yarn.lock workspace dependency resolution
justin808 Nov 22, 2025
ab60c69
Restore accidentally removed webpack bundle cleanup steps in Pro CI
justin808 Nov 23, 2025
b42df93
Address code review feedback: standardize author and organize docs
justin808 Nov 23, 2025
679895d
Fix ESLint default-param-last errors after rebase
justin808 Nov 23, 2025
0c2f96c
Fix Pro ESLint configuration to ignore open-source package
justin808 Nov 23, 2025
ef7e98c
Fix prepare scripts to avoid yarn deadlock during install
justin808 Nov 23, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes.
523 changes: 523 additions & 0 deletions .claude/docs/analysis/CI_FAILURES_2024-11-21.md

Large diffs are not rendered by default.

File renamed without changes.
276 changes: 276 additions & 0 deletions .claude/docs/analysis/INDEX.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,276 @@
# React on Rails Monorepo Migration - Analysis Index

This directory contains comprehensive analysis of the React on Rails monorepo migration status and recommendations.

## Documents Overview

### 1. CI_FAILURES_2024-11-21.md (CURRENT BLOCKER - 24 KB) 🔴

**Critical CI failure analysis for justin808/monorepo-completion branch**

**Status**: NOT READY TO MERGE - 3 failing test suites, 1 hung test

Contains:

- Executive summary of all test failures
- Root cause analysis for each failure
- Comparison with base commit (all tests passing)
- Suspicious commits that likely introduced issues
- Detailed debugging strategy and fix recommendations
- Prevention strategies for future regressions

**Use when**: Debugging current CI failures, planning fixes, understanding what broke

---

### 2. MONOREPO_MIGRATION_ANALYSIS.md (PRIMARY - 16 KB)

**Comprehensive technical analysis of the entire monorepo migration**

Contains 12 detailed sections:

- Executive summary with current phase status
- Directory structure analysis (current vs target)
- YALC publishing configuration review
- Build and package scripts examination
- Documentation status
- Migration TODOs and issues
- CI/CD configuration analysis
- What's working and what needs attention
- Critical dependencies and interactions
- Key files to monitor
- Detailed next steps recommendations
- Success criteria definition

**Use when**: You need complete technical details, planning next phases, or understanding dependencies

### 3. MIGRATION_QUICK_REFERENCE.md (REFERENCE - 6.8 KB)

**Quick lookup guide with status dashboards and checklists**

Contains:

- Migration phase status overview
- Directory structure comparison table
- YALC workflow comparison
- Path reference guide (CRITICAL)
- Status tables for all components
- Testing checklists
- Common issues and solutions
- Key metrics
- Next actions breakdown

**Use when**: You need quick answers, status updates, or testing guidance

### 4. CLAUDE_MD_UPDATES.md (SUPPORTING - 11 KB)

**Documentation of CLAUDE.md improvements for monorepo**

Details improvements to project guidelines including:

- Monorepo-specific development instructions
- Workspace management guidance
- Build and testing updates
- CI configuration notes

**Use when**: Learning about updated developer guidelines

### 5. claude-md-improvements.md (SUPPORTING - 8 KB)

**Additional CLAUDE.md enhancement recommendations**

Suggested improvements for developer experience in monorepo context.

**Use when**: Reviewing documentation enhancement opportunities

### 6. pr-splitting-strategy.md (STRATEGIC - 12 KB)

**Strategy guide for breaking large PRs into smaller ones**

Contains:

- When to split a large PR (indicators and decision criteria)
- Strategy for identifying independent commits
- Step-by-step splitting process
- Real-world example: How to split PR #2069
- Benefits, anti-patterns, and decision tree
- Template for announcing PR splits

**Use when**: Facing complex CI failures in large PRs, planning PR strategy, deciding whether to split

---

## Related Documentation

Outside the analysis directory:

- **PR Splitting Strategy**: `/.claude/docs/pr-splitting-strategy.md` (splitting large PRs)
- **Main Migration Plan**: `/docs/MONOREPO_MERGER_PLAN.md` (authoritative source)
- **Path Management Guide**: `/.claude/docs/managing-file-paths.md` (validation procedures)
- **Build Script Testing**: `/.claude/docs/testing-build-scripts.md` (artifact verification)
- **CI Monitoring**: `/.claude/docs/master-health-monitoring.md` (CI status checks)
- **Contributing Guide**: `/CONTRIBUTING.md` (developer instructions)

Comment on lines +103 to +113
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major

Remove duplicate "Related Documentation" section.

Lines 191–199 duplicate the "Related Documentation" section from lines 103–113 with nearly identical content. Keep the first occurrence (lines 103–113) and remove the duplicate.

Apply this diff:

 ## Document Features
 
 ### Color Coding in Quick Reference
 
 - ✅ Working/Complete items
 - ❌ Items needing updates
 - 🔄 In-progress items
 - ⏳ Planned items
 - ⚠️ Critical issues
 
 ### Sections in Analysis
 
 - 📋 Executive summaries
 - 🏗️ Architecture details
 - ⚙️ Configuration specifics
 - 📊 Status and metrics
 - 🔍 Issues and risks
 - 📝 Recommendations
 - ✓ Checklists and criteria
 
-## Related Documentation
-
-Outside this analysis directory:
-
-- **Main Migration Plan**: `/docs/MONOREPO_MERGER_PLAN.md` (authoritative source)
-- **Path Management Guide**: `/managing-file-paths.md` (validation procedures)
-- **Build Script Testing**: `/testing-build-scripts.md` (artifact verification)
-- **CI Monitoring**: `/master-health-monitoring.md` (CI status checks)
-- **Contributing Guide**: `/CONTRIBUTING.md` (developer instructions)
-
 ## Workflow Tips

Also applies to: 191-199

🤖 Prompt for AI Agents
In .claude/docs/analysis/INDEX.md around lines 103–113 there is a "Related
Documentation" section that is duplicated at lines 191–199; remove the duplicate
block at 191–199 and keep the first occurrence intact, making sure to also
remove any extra blank lines or duplicated bullets left behind and update
surrounding spacing so the file remains clean and properly formatted.

---

## Quick Navigation

### I Need To...

**Fix current CI failures**
→ Read: CI_FAILURES_2024-11-21.md (MOST URGENT)

**Decide whether to split a large PR**
→ Read: pr-splitting-strategy.md (for complex PRs with multiple failures)

**Understand the current state**
→ Read: Executive Summary in MONOREPO_MIGRATION_ANALYSIS.md

**Plan Phase 3 or 4 work**
→ Read: "Recommendations for Next Steps" in MONOREPO_MIGRATION_ANALYSIS.md

**Find path references to update**
→ Read: "Build Scripts - Path Reference Guide" in MIGRATION_QUICK_REFERENCE.md

**Check what's working/broken**
→ Read: "What's Working Well" and "Critical Issues" in MONOREPO_MIGRATION_ANALYSIS.md

**Run tests before committing**
→ Read: "Testing Checklist Before Merging" in MIGRATION_QUICK_REFERENCE.md

**Fix a specific issue**
→ Read: "Common Issues & Solutions" in MIGRATION_QUICK_REFERENCE.md

**Monitor file changes**
→ Read: "Key Files to Monitor" in MONOREPO_MIGRATION_ANALYSIS.md

**Setup workspace development**
→ Read: CLAUDE_MD_UPDATES.md and claude-md-improvements.md

## Key Facts at a Glance

**Current Phase**: Phase 5 (Pro Node Renderer Package) - COMPLETE
**Next Phase**: Phase 6 (Documentation & Polish)
Comment on lines +152 to +153
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

CRITICAL: Resolve conflicting Phase 5 status information.

The document contradicts itself on Phase 5 status:

Readers will be confused. Based on the PR objectives and CI_FAILURES documentation, Phase 5 is currently IN PROGRESS with failing tests, not complete. Update the "Key Facts at a Glance" section to reflect this:

Apply this diff to clarify the current state:

 ## Key Facts at a Glance
 
-**Current Phase**: Phase 5 (Pro Node Renderer Package) - COMPLETE
-**Next Phase**: Phase 6 (Documentation & Polish)
+**Current Phase**: Phase 5 (Pro Node Renderer Package) - IN PROGRESS (PR #2069 - CI FAILING)
+**Next Phase**: Phase 6 (Documentation & Polish) - Blocked until Phase 5 merges
 **Estimated Timeline**: Phases 1-5 complete, Phases 6-7 remaining

Also applies to: 251-256

🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

152-152: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

🤖 Prompt for AI Agents
In .claude/docs/analysis/INDEX.md around lines 152–153 (and also update the
conflicting text at lines 251–256), the "Key Facts at a Glance" currently shows
"Phase 5 (Pro Node Renderer Package) - COMPLETE" which contradicts the later
section stating Phase 5 is IN PROGRESS with failing CI; change the Phase 5
status in the Key Facts section to "Phase 5 (Pro Node Renderer Package) - IN
PROGRESS (PR #2069 - CI FAILING / NOT READY TO MERGE)" and ensure the Next Phase
remains "Phase 6 (Documentation & Polish)"; make the wording consistent between
both locations and include the PR number and CI failing note so readers see the
current state unambiguously.

**Estimated Timeline**: Phases 1-5 complete, Phases 6-7 remaining

**Directory Structures**:

- Surabaya-v1: `packages/` workspaces (fully implemented)
- Three packages: react-on-rails, react-on-rails-pro, react-on-rails-pro-node-renderer

**Critical Risk**: Path validation for yalc publish

- Past incident: 7-week silent failure (Sept 2024)
- Prevention: Always test `yarn run yalc.publish` manually

**Packages in Migration**:

- 2 Ruby gems (core + pro)
- 3 NPM packages (core + pro + pro-node-renderer)

## Document Features

### Color Coding in Quick Reference

- ✅ Working/Complete items
- ❌ Items needing updates
- 🔄 In-progress items
- ⏳ Planned items
- ⚠️ Critical issues

### Sections in Analysis

- 📋 Executive summaries
- 🏗️ Architecture details
- ⚙️ Configuration specifics
- 📊 Status and metrics
- 🔍 Issues and risks
- 📝 Recommendations
- ✓ Checklists and criteria

## Related Documentation

Outside this analysis directory:

- **Main Migration Plan**: `/docs/MONOREPO_MERGER_PLAN.md` (authoritative source)
- **Path Management Guide**: `/managing-file-paths.md` (validation procedures)
- **Build Script Testing**: `/testing-build-scripts.md` (artifact verification)
- **CI Monitoring**: `/master-health-monitoring.md` (CI status checks)
- **Contributing Guide**: `/CONTRIBUTING.md` (developer instructions)

## Workflow Tips

### Before Starting Work

1. Read MIGRATION_QUICK_REFERENCE.md phase status
2. Check "What Needs Attention" section
3. Review relevant next steps

### During Development

1. Keep MIGRATION_QUICK_REFERENCE.md open for reference
2. Use path reference guide when modifying configs
3. Follow testing checklists before committing

### Before Committing

1. Verify all paths in MIGRATION_QUICK_REFERENCE.md
2. Run testing checklist
3. Validate build artifacts

### Before Merging PR

1. Confirm all tests pass
2. Manual verification of yalc publish
3. Documentation updates aligned

## Contact & Updates

These documents were generated on: 2025-11-19

Updates to analysis:

- Document updates based on phase completion
- New issues/findings during implementation
- Success criteria validation

## Completed Phases

**Phase 3**: ✅ Pre-Monorepo Structure Preparation (Completed)

- Validated surabaya-v1 state
- Updated all paths
- Tested workspace commands

**Phase 4**: ✅ Final Monorepo Restructuring (Completed)

- Consolidated Pro package
- Merged CI systems
- Updated publishing process

**Phase 5**: 🔴 Pro Node Renderer Package Extraction (IN PROGRESS - PR #2069 - CI FAILING)

- ✅ Extracted node-renderer as separate workspace package
- ✅ Updated build and publishing workflows
- ❌ CI/CD integration BROKEN - 3 test failures + 1 hung test
- **Status**: NOT READY TO MERGE - See CI_FAILURES_2024-11-21.md

## Future Phases

**Phase 6**: ⏳ Documentation & Polish (Planned)

- Documentation consolidation
- Developer experience improvements
- Final polish and refinements

**Phase 7**: ⏳ Post-Migration Cleanup & Deprecation (Planned)

- Legacy structure removal
- Deprecation notices
- Migration guide finalization

---

Last Updated: 2025-11-21
Status: Phase 5 IN PROGRESS - CI Failures Must Be Fixed Before Merge
**BLOCKER**: See CI_FAILURES_2024-11-21.md for complete failure analysis
Loading
Loading