Call BeforeSaveHook in shuttermint chain processing and add metrics #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannikluhn
force-pushed
the
fix-shuttermint-handling
branch
from
775a3a2 to
5f91975
Compare
ulope
approved these changes
Oct 28, 2025
Comment on lines
+214
to
+219
| for range receivers { | ||
| keypermetrics.MetricsKeyperDKGMessagesSent.WithLabelValues( | ||
| eonLabel, | ||
| keypermetrics.DKGMessageTypePolyEval, | ||
| ).Inc() | ||
| } |
Contributor
There was a problem hiding this comment.
You can use .Add() instead to pass a number directly
Contributor
Author
There was a problem hiding this comment.
didn't like add because it takes a float, but I guess that just means it's float internally anyway
When handling blocks, we didnt' call the BeforeSaveHook, leading to some outgoing messages to be dropped. For clarity, we now also sync the shuttermint state cache with the db at each block (even though this is not strictly necessary).
jannikluhn
force-pushed
the
fix-shuttermint-handling
branch
from
5f91975 to
9e45785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.