Skip to content

Conversation

@chintankavathia
Copy link
Member

share common karma config and also remove test config of demo app as there are no tests.

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

share common karma config and also remove test config of demo app as there are no tests.
@chintankavathia chintankavathia marked this pull request as ready for review November 6, 2025 04:58
@chintankavathia chintankavathia requested a review from a team as a code owner November 6, 2025 04:58
Copy link
Member

@spike-rabbit spike-rabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of deleting unused configurations, but I don't see that we need the shared file.
I don't think we are planning to introduce unit tests for the demo. @fh1ch opinion?

@fh1ch
Copy link
Member

fh1ch commented Nov 9, 2025

I am in favor of deleting unused configurations, but I don't see that we need the shared file. I don't think we are planning to introduce unit tests for the demo. @fh1ch opinion?

@spike-rabbit I'm 100% with you on this one. Deleting the unit-test configuration as well as the Angular CLI cfg for it makes absolutely sense, we currently don't plan to introduce any unit-test for the demo and I frankly also can't think of any valid use-cases in doing so. But I also don't think we need a shared file nor deviate from Angular here, since we should anyway move to Vitest in the mid-term. But maybe I also lack context, since What is the current behavior?/What is the new behavior? was not provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants