Skip to content

Add retry logic for rate limit errors #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2025
Merged

Add retry logic for rate limit errors #61

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15fc69d
Add retry logic for rate limit errors
woefe Oct 27, 2025
17aa431
Quicker retry on rate limit errors
woefe Oct 30, 2025
c4dc747
Fix linter
woefe Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion vilocify/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# SPDX-FileCopyrightText: 2025 Siemens AG
# SPDX-License-Identifier: MIT

import logging
import time
from dataclasses import dataclass

import requests
Expand All @@ -17,6 +17,10 @@ def __init__(self, error_code: int, message: str):
self.message = message


class RateLimitError(Exception):
"""Raised for rate limiting."""


@dataclass
class JSONAPIError:
title: str = ""
Expand Down Expand Up @@ -47,6 +51,17 @@ def from_response(code: int, response_json: JSON) -> "JSONAPIRequestError":


def _request(verb: str, url: str, json: JSON = None, params: dict[str, str] | None = None) -> JSON:
for i in range(10):
try:
return _rate_limited_request(verb, url, json, params)
except RateLimitError:
logger.debug("Pausing due to rate limit")
time.sleep(1)

raise RequestError(requests.codes.too_many_requests, "Ratelimit exceeded and retry failed")


def _rate_limited_request(verb: str, url: str, json: JSON = None, params: dict[str, str] | None = None) -> JSON:
logger.debug("%s: url=%s, params=%s, json=%s", verb.upper(), url, params, json)
response = api_config.client.request(
verb, url, timeout=api_config.request_timeout_seconds, json=json, params=params
Expand All @@ -63,6 +78,9 @@ def _request(verb: str, url: str, json: JSON = None, params: dict[str, str] | No
if "Server-Timing" in response.headers:
logger.debug("server-timing: %s", response.headers["Server-Timing"])

if response.status_code == requests.codes.too_many_requests:
raise RateLimitError()

if not response.ok:
raise JSONAPIRequestError.from_response(response.status_code, response_json)

Expand Down