Some updates to attempt to optimize our Dockerfile #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

landonxjames merged 16 commits into main from landonxjames/actions-space

Nov 25, 2025

Contributor

landonxjames commented Nov 21, 2025 •

edited

Loading

Successfully built locally, now to see if CI passes

Motivation and Context

CI for PRs from forks has been failing on Acquire Build Image with error:

Saving base image for use in later jobs...
write /home/runner/work/smithy-rs/smithy-rs/.docker_temp_1730454122: no space left on device

The image build would succeed, but the task would fail when saving the built image locally.

Description

Attempted to slim down the Dockerfile, but only managed to knock off ~30MB (out of 1.8GB), so not much luck there. Was able to create more room by adding a new action that does:

run: |
  sudo rm -rf /usr/share/dotnet
  sudo rm -rf "$AGENT_TOOLSDIRECTORY"

and deletes some of the included tools we don't use. In my testing this freed up ~5GB which should be enough to allow builds to succeed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

landonxjames added 2 commits

November 20, 2025 20:06


          Some updates to attempt to optimize our Dockerfile

a615f3b

Successfully built locally, now to see if CI passes


          Merge branch 'main' into landonxjames/actions-space

874bdb5

github-actions bot commented Nov 21, 2025

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.


          Small update to not delete a cargo related folder

24c091a

github-actions bot commented Nov 21, 2025

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.


          Update local_tools copy

cbda5b5

github-actions bot commented Nov 21, 2025

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.


          Update Dockerfile, add back go/py 3.9

d279a76

github-actions bot commented Nov 21, 2025

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.


          Add back cmake

f557077

github-actions bot commented Nov 21, 2025

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

landonxjames added 2 commits

November 22, 2025 20:55


          Add bc back to image

9bdea6d


          Add .dockerignore

90834b8

github-actions bot commented Nov 23, 2025

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.


          Update .dockerignore

77a5456

github-actions bot commented Nov 24, 2025

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

landonxjames added 3 commits

November 24, 2025 10:18


          Update local_tools copy to only copy bin

173c7e1


          Chown opt/cargo separate from COPY

c6ebc0e


          Add small set of unused dep removals to CI workflows

d10136c

github-actions bot commented Nov 24, 2025

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

landonxjames added 3 commits

November 24, 2025 13:14


          setfacl for opt/cargo

65e5adf


          install acl to get setfacl

8c78745


          backing out the opt/cargo/bin change

d5252db

github-actions bot commented Nov 24, 2025

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.


          Merge branch 'main' into landonxjames/actions-space

66f7bcb

github-actions bot commented Nov 25, 2025

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

landonxjames marked this pull request as ready for review

November 25, 2025 22:37

landonxjames requested review from a team as code owners

November 25, 2025 22:37

aajtodd approved these changes

View reviewed changes

landonxjames merged commit d38a6c5 into main

92 of 94 checks passed

landonxjames deleted the landonxjames/actions-space branch

November 25, 2025 22:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet