createSignal updates #1356
Open
createSignal updates #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
❌ Deploy Preview for solid-docs failed. Why did it fail? →
|
brenelz
reviewed
Dec 1, 2025
brenelz
approved these changes
Dec 1, 2025
Collaborator
|
Deploy preview failed for some reason |
Collaborator
|
Looks like someone already updated createComputed here |
atk
reviewed
Dec 2, 2025
amirhhashemi
reviewed
Dec 2, 2025
amirhhashemi
reviewed
Dec 2, 2025
amirhhashemi
reviewed
Dec 2, 2025
amirhhashemi
reviewed
Dec 2, 2025
amirhhashemi
reviewed
Dec 2, 2025
Collaborator
amirhhashemi
left a comment
amirhhashemi
left a comment
There was a problem hiding this comment.
One overall issue is that these reference pages don't strictly follow Diataxis. They include quite a bit of explanatory material and an explanatory tone. I've been spending a lot of time trying to ensure that at least the reference pages follow Diataxis more strictly. Honestly, I'm not sure it's worth the effort at this point. If improving Diataxis compliance isn't a goal of this PR, I'm perfectly fine with that.
amirhhashemi
requested changes
Dec 2, 2025
Collaborator
amirhhashemi
left a comment
amirhhashemi
left a comment
There was a problem hiding this comment.
I highly recommend running Prettier on these. There are a lot of formatting issues.
…ate createSignal page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.