-
Notifications
You must be signed in to change notification settings - Fork 431
Concept Shippable Response Plans #3803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
pyth0n1c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not mix the python files and schema files in the same directory. Inside of the response_templates directory, I would probably have:
merged_response_templates/ - exactly as it is today
either in merged_response_templates/bin or .github/workflows/response_templates/ - template_script.py, validate_response_templates.py, mcopenapi_public.yml (I would convert this to yml not yaml, for consistency with the rest of the security_content repo, even if what the team provided was yaml)
I make this recommendation as there is no other "code" in the security_content repo other than the code which lives in the .github folder for use during CI/CD
.github/workflows/response_templates/validate_response_templates.py
Outdated
Show resolved
Hide resolved
Moved |
pyth0n1c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little more feedback around organization and fixing a pre-existing deficiency in the build.yml workflow.
Details
This PR adds response templates to security_content repo:
response_templates/*.json: Response templates provided by the response templates team.github/workflows/response_templates/template_script.py: Script provided by the response templates team, which provides functionality merged different versions response templates and generate manifest file of response templates..github/workflows/response_templates/validate_response_templates.py: Script to validate response templates usingDraft7Validatorwith provided OpenAPI spec from the response templates team.github/workflows/response_templates/mcopenapi_public.yaml.github/workflows/build.yml: Add upload ofdist/api..github/workflows/build-response-templates.yml: Workflow to build merged response templates and validate response templates on push/PR.Checklist
<platform>_<mitre att&ck technique>_<short description>nomenclatureThe update doesn't have impact to detections related. Below is the screenshot of build-response-templates workflow:
Notes For Submitters and Reviewers
buildCI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.