Skip to content

debug-mode: report error when query is not simulatable #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

debug-mode: report error when query is not simulatable #243

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92ab5ba
debug-mode: throw exception when query is not simulatable
staabm Feb 4, 2022
1e5f807
Update MysqliQueryReflector.php
clxmstaab Feb 4, 2022
d889c00
fix
clxmstaab Feb 4, 2022
b08a53c
fix
clxmstaab Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/QueryReflection/MysqliQueryReflector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@ public function getResultType(string $queryString, int $fetchType): ?Type
{
$result = $this->simulateQuery($queryString);
if (!\is_array($result)) {
if (QueryReflection::getRuntimeConfiguration()->isDebugEnabled() && $result instanceof mysqli_sql_exception) {
throw new UnresolvableQueryException(sprintf("Cannot simulate query\n %s \nbecause of a sql error: %s", $queryString, $result->getMessage()));
Copy link
Owner Author

@staabm staabm Feb 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: separate exception type

}

return null;
}

Expand Down