Skip to content

chore: Add support Superset 6.0.0-rc2 #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 11, 2025
Merged

chore: Add support Superset 6.0.0-rc2 #680

merged 9 commits into from
Nov 11, 2025

Conversation

@NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Nov 10, 2025 •
edited
Loading

Part of stackabletech/docker-images#1329 (comment)

Caution

Depends on stackabletech/docker-images#1337 being merged and built.

Description

Add Superset 6.0.0 support.

Warning

Flask AppBuilder 5 no longer has the AUTH_OID module. It is possible a user still relies on this for old Superset versions.

Do we need to make this conditional?

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added run
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@NickLarsenNZ
fix: Remove deprecated and removed import
d61e60b 
Flask AppBuilder 5 no longer has the AUTH_OID module. It is possible a user still relies on this for old Superset versions.
@NickLarsenNZ
fix: Set required config (to an empty value
839c07c 
Flask AppBuilder 5, for some reason, requires `RECAPTCHA_PUBLIC_KEY` to be set, or the UI cannot be used, and the following error is emitted on the container console:

```
  File "/stackable/app/lib64/python3.11/site-packages/superset/views/base.py", line 417, in cached_common_bootstrap_data
    frontend_config["RECAPTCHA_PUBLIC_KEY"] = app.config["RECAPTCHA_PUBLIC_KEY"]
                                              ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'RECAPTCHA_PUBLIC_KEY'
```
@NickLarsenNZ
chore: Use to_owned for &str -> String
ade0473
@NickLarsenNZ
test(kuttl): Add Superset 6.0.0-rc2 to test-definitions.
bf89e05 
This requires the product image to be merged and built: stackabletech/docker-images#1337
@NickLarsenNZ NickLarsenNZ self-assigned this Nov 10, 2025
@adwk67 adwk67 self-requested a review November 10, 2025 10:43
@NickLarsenNZ NickLarsenNZ mentioned this pull request Nov 10, 2025
Open
13 tasks
@NickLarsenNZ NickLarsenNZ changed the title fix: Remove deprecated and removed import chore: Add Superset 6.0.0-rc2 Nov 10, 2025
@NickLarsenNZ NickLarsenNZ changed the title chore: Add Superset 6.0.0-rc2 chore: Add support Superset 6.0.0-rc2 Nov 10, 2025
NickLarsenNZ
NickLarsenNZ commented Nov 10, 2025
View reviewed changes
@NickLarsenNZ NickLarsenNZ mentioned this pull request Nov 10, 2025
Merged
3 tasks
adwk67
adwk67 approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with 4.1.4 and 6.0.0-rc2 builds from stackabletech/docker-images#1337.
Only thing I noticed is that the opa tests are bit ropey when run in parallel, though I didn't look into this in detail.

Test runs 
--- FAIL: kuttl (2647.66s)
    --- FAIL: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/ldap_superset-4.0.2_ldap-authentication-insecure-tls_openshift-false (137.40s)
        --- PASS: kuttl/harness/logging_superset-4.0.2_openshift-false (148.77s)
        --- PASS: kuttl/harness/external-access_superset-4.0.2_openshift-false (128.40s)
        --- PASS: kuttl/harness/external-access_superset-6.0.0-rc2_openshift-false (128.70s)
        --- PASS: kuttl/harness/external-access_superset-4.1.4_openshift-false (123.46s)
        --- PASS: kuttl/harness/external-access_superset-4.1.2_openshift-false (278.63s)
        --- PASS: kuttl/harness/oidc_superset-6.0.0-rc2_openshift-false (185.68s)
        --- FAIL: kuttl/harness/opa_superset-6.0.0-rc2_opa-latest-1.8.0_openshift-false (211.98s)
        --- FAIL: kuttl/harness/opa_superset-4.1.4_opa-latest-1.8.0_openshift-false (208.80s)
        --- PASS: kuttl/harness/opa_superset-4.1.2_opa-latest-1.8.0_openshift-false (187.24s)
        --- PASS: kuttl/harness/opa_superset-4.0.2_opa-latest-1.8.0_openshift-false (186.51s)
        --- PASS: kuttl/harness/resources_superset-latest-6.0.0-rc2_openshift-false (135.11s)
        --- PASS: kuttl/harness/smoke_superset-6.0.0-rc2_openshift-false (127.96s)
        --- PASS: kuttl/harness/smoke_superset-4.1.4_openshift-false (96.54s)
        --- PASS: kuttl/harness/smoke_superset-4.1.2_openshift-false (100.28s)
        --- PASS: kuttl/harness/druid-connection_superset-6.0.0-rc2_openshift-false (79.53s)
        --- PASS: kuttl/harness/smoke_superset-4.0.2_openshift-false (99.80s)
        --- PASS: kuttl/harness/druid-connection_superset-4.1.4_openshift-false (77.98s)
        --- PASS: kuttl/harness/druid-connection_superset-4.1.2_openshift-false (83.26s)
        --- PASS: kuttl/harness/druid-connection_superset-4.0.2_openshift-false (79.54s)
        --- PASS: kuttl/harness/cluster-operation_superset-latest-6.0.0-rc2_openshift-false (126.15s)
        --- PASS: kuttl/harness/ldap_superset-4.1.4_ldap-authentication-server-verification-tls_openshift-false (146.33s)
        --- PASS: kuttl/harness/oidc_superset-4.1.4_openshift-false (200.81s)
        --- PASS: kuttl/harness/oidc_superset-4.1.2_openshift-false (195.44s)
        --- PASS: kuttl/harness/oidc_superset-4.0.2_openshift-false (170.76s)
        --- PASS: kuttl/harness/ldap_superset-6.0.0-rc2_ldap-authentication-server-verification-tls_openshift-false (120.98s)
        --- PASS: kuttl/harness/ldap_superset-6.0.0-rc2_ldap-authentication-no-tls_openshift-false (73.36s)
        --- PASS: kuttl/harness/ldap_superset-4.1.2_ldap-authentication-no-tls_openshift-false (110.01s)
        --- PASS: kuttl/harness/ldap_superset-4.1.4_ldap-authentication-no-tls_openshift-false (110.00s)
        --- PASS: kuttl/harness/ldap_superset-4.1.2_ldap-authentication-server-verification-tls_openshift-false (105.82s)
        --- PASS: kuttl/harness/ldap_superset-4.1.4_ldap-authentication-insecure-tls_openshift-false (210.74s)
        --- PASS: kuttl/harness/ldap_superset-4.0.2_ldap-authentication-server-verification-tls_openshift-false (98.08s)
        --- PASS: kuttl/harness/ldap_superset-4.1.2_ldap-authentication-insecure-tls_openshift-false (112.82s)
        --- PASS: kuttl/harness/ldap_superset-4.0.2_ldap-authentication-no-tls_openshift-false (107.19s)
        --- PASS: kuttl/harness/logging_superset-4.1.4_openshift-false (151.56s)
        --- PASS: kuttl/harness/ldap_superset-6.0.0-rc2_ldap-authentication-insecure-tls_openshift-false (123.03s)
        --- PASS: kuttl/harness/logging_superset-4.1.2_openshift-false (161.48s)
        --- PASS: kuttl/harness/logging_superset-6.0.0-rc2_openshift-false (163.44s)
FAIL

--- FAIL: kuttl (421.50s) // in parallel
    --- FAIL: kuttl/harness (0.00s)
        --- FAIL: kuttl/harness/opa_superset-4.0.2_opa-latest-1.8.0_openshift-false (204.78s)
        --- FAIL: kuttl/harness/opa_superset-4.1.4_opa-latest-1.8.0_openshift-false (206.78s)
        --- PASS: kuttl/harness/opa_superset-6.0.0-rc2_opa-latest-1.8.0_openshift-false (215.23s)
        --- PASS: kuttl/harness/opa_superset-4.1.2_opa-latest-1.8.0_openshift-false (213.92s)
FAIL

--- PASS: kuttl (680.63s) // parallel = 1
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/opa_superset-4.0.2_opa-latest-1.8.0_openshift-false (167.00s)
        --- PASS: kuttl/harness/opa_superset-4.1.4_opa-latest-1.8.0_openshift-false (172.06s)
        --- PASS: kuttl/harness/opa_superset-6.0.0-rc2_opa-latest-1.8.0_openshift-false (173.85s)
        --- PASS: kuttl/harness/opa_superset-4.1.2_opa-latest-1.8.0_openshift-false (166.94s)
PASS

@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Nov 10, 2025

LGTM. Tested with 4.1.4 and 6.0.0-rc2 builds from stackabletech/docker-images#1337. Only thing I noticed is that the opa tests are bit ropey when run in parallel, though I didn't look into this in detail.
Test runs

Yeah I had some flakiness with both OPA and LDAP tests. I considered that external to this change.

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main with commit 49b63b3 Nov 11, 2025
17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the superset-6.0.0-rc2 branch November 11, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer left review comments

@adwk67 adwk67 adwk67 approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NickLarsenNZ @adwk67 @sbernauer