-
Notifications
You must be signed in to change notification settings - Fork 23
add filbeat restart to complement the go-w on manifest.yml #2005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stackhpc/2025.1
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a handler to restart the filebeat service when the permissions of its alert manifest file are changed. The change is logical and improves the robustness of the configuration. I've suggested one improvement to use a variable for the service name in the new handler, which aligns with best practices for Ansible roles and improves maintainability.
|
s/compliment/complement/ 😉 |
Can you update the commit message with |
d2a3a72 to
a9dd520
Compare
Done |
After permission fix the filebeat service is still stopped, it needs to be restarted.