Update prometheus rules for job rename #2018
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates Prometheus alert rules to reflect the renaming of the redfish-exporter-seed job to redfish-exporter. The changes correctly update the job name in the alert expressions. I have added one comment with a suggestion to fully align the alert rule with the intent described in the pull request (changing the severity to 'warning') and to improve its actionability by adding annotations.
MoteHue
approved these changes
Dec 1, 2025
redfish-exporter-seed was renamed redfish-exporter in: 782f689 This updates the rules to match. Effectively making failed redfish scrapes warnings again.
Alex-Welsh
force-pushed
the
2025.1/bugfix/redfish-spam
branch
from
288df1f to
5a4db4c
Compare
Alex-Welsh
requested a deployment
to
SMS Lab
GitHub Actions
In progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redfish-exporter-seed was renamed redfish-exporter in:
782f689
This updates the rules to match and thereby reduces the sensitivity of the alert.