-
Notifications
You must be signed in to change notification settings - Fork 1
Update RabbitMQ mirror URL #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Alex-Welsh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a recent change in RabbitMQ's package distribution strategy by updating the repository URL used for Ubuntu Noble. The modification ensures that systems relying on this repository can continue to access RabbitMQ server packages without interruption, aligning with the new official distribution channels. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly identifies the need to update RabbitMQ repository URLs due to their recent move. The change for RabbitMQ - Server - Ubuntu Noble is a good start.
However, the update is incomplete as other RabbitMQ repositories defined in ansible/inventory/group_vars/all/package-repos still use the old URLs. To ensure consistency and prevent potential sync failures, please update all RabbitMQ repository URLs as announced in the blog post.
Specifically, the following repositories should be updated:
- Debian/Ubuntu Repositories:
RabbitMQ - Erlang - Ubuntu Noble(line 181): The URL should be updated to use the newdeb1.rabbitmq.comdomain.
- RPM-based Repositories:
RabbitMQ - Erlang(el8, line 358): Should be updated fromyum1.rabbitmq.comtorpm1.rabbitmq.com.RabbitMQ - Server(el8, line 368): Should be updated fromyum2.rabbitmq.comtorpm1.rabbitmq.com, and the path from/rabbitmq/to/rabbitmq-server/.RabbitMQ - Erlang - RHEL 9(line 755): Should be updated fromyum1.rabbitmq.comtorpm1.rabbitmq.com.RabbitMQ - Server - RHEL 9(line 785): Should be updated fromyum2.rabbitmq.comtorpm1.rabbitmq.com, and the path from/rabbitmq/to/rabbitmq-server/.
In addition to these missing changes, I have a specific suggestion for the URL format in the change you've made to ensure it is consistent with other repository definitions in this file.
RabbitMQ moved all their package repos https://www.rabbitmq.com/blog/2024/08/11/package-repository-updates
Successful sync https://github.com/stackhpc/stackhpc-release-train/actions/runs/19495936348/job/55798032958
Matches upstream change https://review.opendev.org/c/openstack/kolla/+/967475