Skip to content

Conversation

@Ankit-Trivedi-02
Copy link

@Ankit-Trivedi-02 Ankit-Trivedi-02 commented Nov 22, 2025

This PR fixes the JavaScript lint issues reported for
lib/node_modules/@stdlib/math/base/special/sqrt/scripts/precision.js
in the CI lint workflow.

Lint issues addressed

Removed TODO comment (no-warning-comments)

Replaced bare require('compute-*') with explicit relative paths and .js extensions (stdlib/require-file-extensions)

Replaced new Array() with array literal and push (stdlib/no-new-array)

Replaced Math.sqrt with @stdlib/math/base/special/sqrt (stdlib/no-builtin-math)

Removed console.log statements (no-console)

Result

This resolves all linting problems that previously caused the CI workflow to fail for this file.

Notes

This update modifies a built file under lib/ to validate lint fixes.
A follow-up PR can apply equivalent changes to the canonical source/template if required by maintainers.

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Nov 22, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 22, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/sqrt $\color{green}161/161$
$color{green}+100.00%$
$\color{green}4/4$
$color{green}+100.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}161/161$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

…no-new-array, use @StdLib sqrt, remove console/TODO)

Signed-off-by: Ankit <ankittrivedi0210@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants