Fix tests for sunpy 7.1 #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaloney
force-pushed
the
bugfix-tests-for-sunpy71
branch
3 times, most recently
from
ae8adfa to
ceff2ed
Compare
samaloney
commented
Dec 2, 2025
samaloney
force-pushed
the
bugfix-tests-for-sunpy71
branch
from
ceff2ed to
2f29fc4
Compare
Member
Author
|
Test fails are due to sunpy/sunpy#8442 |
Member
|
I've released rc2 and restarted all the CI. |
Cadair
approved these changes
Dec 3, 2025
Member
|
docbuild should pass once sunpy/sunpy#8444 hits a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fix test for change in sunpy7.1 where
Fido.seachno longer raises error but stores any encountered errors on a.errorsattribute.