Skip to content

Conversation

@lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Oct 27, 2025

Fixes #14824.

I'll check off the other checklist items when I get a free second, but the patch itself is good AFAICT


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025

🦋 Changeset detected

Latest commit: 5a67e55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lishaduck
Copy link
Contributor Author

@lishaduck
Copy link
Contributor Author

lishaduck commented Oct 27, 2025

Locally, fail
[chromium-build] › test/cross-platform/client.test.js:386:2 › Scrolling › scroll is restored after hitting the back button
[chromium-build] › test/cross-platform/client.test.js:924:2 › Routing › responds to

submission without reload

I think they're flaky? scroll is restored after hitting the back button is related to hash routing, but shouldn't affected and isn't hit in CI; form submission is completely unrelated AFAIK.

@dummdidumm dummdidumm changed the title feat: allow hosting hash apps from other html files fix: allow hosting hash apps from other html files Nov 20, 2025
@svelte-docs-bot
Copy link

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dummdidumm dummdidumm merged commit 5b30755 into sveltejs:main Nov 20, 2025
21 of 22 checks passed
@github-actions github-actions bot mentioned this pull request Nov 20, 2025
@lishaduck lishaduck deleted the popuphtml branch November 20, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SvelteKit assumes it's hosted from index.html in hash router

2 participants